Hi Tim,
The change sounds OK to me. The presentation and screening indicators 
will be used from H.225 message, instead of Q.931 header.

I will incorporate in next ooh323c release.

Thank you for change.

Regards,
Avin Patel
Objective Systems, Inc.


Tim King wrote:
> This was not fixed as of the last thread I found. My change is
> At line 1936 (approx, may change   )
> 
> /* Set calling party number  Q931 IE */
>    if(call->callingPartyNumber)
>      ooQ931SetCallingPartyNumberIE(q931msg,
>                             (const char*)call->callingPartyNumber, 1, 0, 
> 1, 1);
> to
> /* Set calling party number  Q931 IE */
>    if(call->callingPartyNumber)
>      ooQ931SetCallingPartyNumberIE(q931msg,
>                             (const char*)call->callingPartyNumber,
>                             1, /* Plan */
>                             0, /* Type */
>                             0, /* Presentation */
>                             0);/* Screening */
> 
> Avin Patel wrote:
>> Hi Pavel,
>> The screening indicator are set by ooh323 stack in H.225 message field.
>> It is not set in Q.931 header.
>>
>> When both fields are present, than considered as conflict, and Q.931 
>> fields are chosen.
>>
>> Can you point me to thread, I can look again if something is missing.
>>
>> Regards,
>> Avin Patel
>> Objective Systems, Inc.
>>
>>
>> Pavel Jezek wrote:
>>   
>>> hello, I would like to report some possible bug found in chan_ooh323 
>>> with asterisk, seems that calling presentation is not working as expected,
>>> I cannot see caller id number, when I call from asterisk to ip phone 
>>> behind callmanager.
>>> when I debug communication, I found, that chan_ooh323  _always_ set 
>>> presentation indicator as "Presentation restricted",
>>> setting SetCallerPres(allowed_passed_screen) before ooh323 dial from 
>>> asterisk to callmanager has no efect for displaying caller id number on 
>>> destination phone  :'(
>>>
>>> from packet dump, wireshark still shows :
>>> Calling party number: '324'
>>> .... ..01 = Screening indicator: User-provided, verified and passed (0x01)
>>> .01. .... = Presentation indicator: Presentation restricted (0x01)
>>>
>>> I think I hit this bug as wrote: Tim King <[EMAIL PROTECTED]> - 2006-06-06 
>>> 04:13: ooh323 in Asterisk and Cisco Call Manager
>>> 2. In ooq931.c line 1936 the undocumented parameters to
>>>  ooQ931SetCallingPartyNumberIE set privacy mode on (always).
>>> .....
>>>
>>> and because some patch for this was included in this thread, I would 
>>> like to ask, if it's included in some current (devel?) chan_ooh323 
>>> version or will be included... thanks.
>>> PJ
>>>
>>>
>>> -------------------------------------------------------------------------
>>> Using Tomcat but need to do more? Need to support web services, security?
>>> Get stuff done quickly with pre-integrated technology to make your job 
>>> easier
>>> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
>>> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
>>> _______________________________________________
>>> ooh323c-devel mailing list
>>> ooh323c-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/ooh323c-devel
>>>
>>>     
>>
>> -------------------------------------------------------------------------
>> Take Surveys. Earn Cash. Influence the Future of IT
>> Join SourceForge.net's Techsay panel and you'll get the chance to share your
>> opinions on IT & business topics through brief surveys - and earn cash
>> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
>> _______________________________________________
>> ooh323c-devel mailing list
>> ooh323c-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/ooh323c-devel
>>
>>   

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
ooh323c-devel mailing list
ooh323c-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ooh323c-devel

Reply via email to