Hmm... I did say on another thread I was planning to disable it, and enable openldap.
I didn't remove it (just disabled) and there was plenty of people wanting to see it go, so lazy consensus applied. Should I revert it? I think using or not binfilter is something that should be left to the distributors to decide, but I will accept to revert this if there are strong feelings about it. Pedro. --- On Thu, 10/27/11, Mathias Bauer <[email protected]> wrote: > Hi, > > did I miss something? I can't remember that we decided to > remove > binfilter from the first AOOo release. And IMHO a default > build without > any configure settings should be what we want to release > (at least it > should be as close to that as possible). > > Regards, > Mathias > > Am 27.10.2011 22:54, schrieb [email protected]: > > > Author: pfg > > Date: Thu Oct 27 20:54:01 2011 > > New Revision: 1190021 > > > > URL: http://svn.apache.org/viewvc?rev=1190021&view=rev > > Log: > > Disable legacy binfilter by default. Use > --enable-binfilter in configure if you need them. > > > > Modified: > > > incubator/ooo/trunk/main/configure.in > > > > Modified: incubator/ooo/trunk/main/configure.in > > URL: > > http://svn.apache.org/viewvc/incubator/ooo/trunk/main/configure.in?rev=1190021&r1=1190020&r2=1190021&view=diff > > > ============================================================================== > > --- incubator/ooo/trunk/main/configure.in (original) > > +++ incubator/ooo/trunk/main/configure.in Thu Oct 27 > 20:54:01 2011 > > @@ -286,8 +286,8 @@ AC_ARG_ENABLE(kde4, > > > if you want to > support both KDE3 and KDE4. > > ],,) > > AC_ARG_ENABLE(binfilter, > > -[ --disable-binfilter > Disable legacy binary file formats > filters > > -],,if ! test -d ./binfilter; then > enable_binfilter=no; fi) > > +[ --enable-binfilter Enable > legacy binary file formats filters > > +],,) > > AC_ARG_ENABLE(rpath, > > [ --disable-rpath > Disable the use of relative paths in > shared libraries > > ],,) > > @@ -1336,13 +1336,13 @@ dnl > ==================================== > > dnl Disable legacy binary file formats filters > > dnl > =================================================================== > > AC_MSG_CHECKING([whether to enable filters for > legacy binary file formats (StarOffice 5.2)]) > > -if test "$enable_binfilter" = "no"; then > > - WITH_BINFILTER="NO" > > - AC_MSG_RESULT([no]) > > -else > > +if test "$enable_binfilter" = "yes"; then > > WITH_BINFILTER="YES" > > BUILD_TYPE="$BUILD_TYPE > BINFILTER" > > AC_MSG_RESULT([yes]) > > +else > > + WITH_BINFILTER="NO" > > + AC_MSG_RESULT([no]) > > fi > > AC_SUBST(WITH_BINFILTER) > > > > > > > > > >
