I thought of that also but there is a reason ... From some past interaction with people from China, for them it's absolutely important to get full acknowledgement for their contributions. It seems like having them may make a difference in their future employment. It's a different country with a different culture and in another project we almost lost an important contributor for something less important than this!
This is also only half fix for the issue. The comments shall be reviewed when the fix is completed. Pedro. --- On Thu, 11/17/11, Ariel Constenla-Haile <[email protected]> wrote: ... > Hello Pedro, * > > On Thu, Nov 17, 2011 at 07:26:08AM -0800, Pedro Giffuni > wrote: > > Committed as revision 1203218. > > > > Thank you very much for your contribution! > > > > Pedro. > > > > + //#115580# fixed by > JingDongChen from China at 2011/11/16 start > + //#115580# fixed by > JingDongChen from China at 2011/11/16 end > > + //#115580# fixed by > JingDongChen from China at 2011/11/16 start > + //#115580# fixed by > JingDongChen from China at 2011/11/16 end > > + //#115580# fixed by > JingDongChen from China at 2011/11/16 start > + //#115580# fixed by > JingDongChen from China at 2011/11/16 end > > + > //#115580# fixed by JingDongChen from > China at 2011/11/16 start > + > //#115580# fixed by JingDongChen from > China at 2011/11/16 end > > + > //#115580# fixed by JingDongChen from > China at 2011/11/16 start > + > //#115580# fixed by JingDongChen from > China at 2011/11/16 end > > + //#115580# fixed by > JingDongChen from China at 2011/11/16 start > + //#115580# fixed by > JingDongChen from China at 2011/11/16 end > > .... > > IMHO those kind of comments shouldn't be commited, the > commit log speaks by > itself, it is redundant to add the issue number, the date > and the author name > to every block of code. Just imagine everyone starts to do > the same, the source > would be a mess. > > Regards > -- > Ariel Constenla-Haile > La Plata, Argentina >
