Hi Regina, I haven't tested the patch but have reviewed it and for me it looks good and I assume you have already built and tested it completely.
I think you can commit in trunk, nice work by the way Juergen On 6/7/12 11:55 AM, Jürgen Schmidt wrote: > On 6/7/12 1:11 AM, Regina Henschel wrote: >> Hi all, >> >> please review the patch attached to >> https://issues.apache.org/ooo/show_bug.cgi?id=111609 >> >> Is such a mail as this necessary? Or will a review request already be >> noticed, when I set the flag in the issue? > > no special sign on the issues mailing list, just that somebody has add > or changed something. So it's probably a good idea to drop a short email > like this one here on the list to raise some awareness. > > Juergen
