On 6/21/12 10:20 AM, Jürgen Schmidt wrote: > On 6/21/12 7:06 AM, li zhang wrote: >> for more information, you can refer to the below link: >> >> http://wiki.services.openoffice.org/wiki/ODT_saving_performance_improvement >> >> On Thu, Jun 21, 2012 at 1:00 PM, li zhang <[email protected]> wrote: >> >>> hi, all >>> I'm zhang li from China. My main focus is performance(loading, saving, >>> asynchronous loading, etc). >>> >>> I have one fix need for review. It is about odt saving. Please check the >>> below for details, thanks! >>> >>> https://issues.apache.org/ooo/show_bug.cgi?id=120030 >>> >>> root cause: >>> Do profiling on a sample file, SfxObjectShell::GenerateAndStoreThumbnail >>> is to be found occypy too much time, and it will call SwFlyFrm::Paint >>> several times, but it's unnecessary to paint thumbnail so many times when >>> saving. >>> >>> solution: >>> When thumbnail is generated and stored, in SwFlyFrm::Paint, current >>> visible rectangle will be compared with fly frame rectangle, if the two >>> rectangles don't intersect, SwFlyFrm::Paint will return, need no repaint. >>> >> > > I will take care of this
I had some problems with building on trunk in general. Nothing that depends on your patch but it takes more time to built and test the patch. Juergen
