Many thanks to all. 2012/6/28 De Bin Lei <[email protected]>
> 2012/6/28 Jürgen Schmidt <[email protected]> > > > On 6/28/12 11:14 AM, Steve Yin wrote: > > > Hi all, > > > > > > This feature has been tested and enabled in Symphony over 2 years. It > > does > > > work. And The hash algorithm is correct. I remember Kohei's aim was to > > > implement almost all protection features like MS Excel includes > different > > > privileges. One possible reason is the current implementation is not > > > complete for Kohei, So he disable the feature by default at that time. > > > However. I think we can enable it safely now. > > > > we should track it then as a new feature for 3.5. I suggest that we > > create a feature task for it. > > > > Thank you for your suggestion, I will help to track it as a feature and > commit the code. > > > Juergen > > > > > > > > On Thu, Jun 28, 2012 at 3:35 PM, Lei Wang <[email protected]> > > wrote: > > > > > >> Hi Jian Yuan, > > >> > > >> The file tabprotection.hxx is created by CWS scheetprotection02. I go > > >> through the comments when this CWS integrated into the trunk. But I do > > not > > >> find any useful information. > > >> > > >> If Excel use another hash algorithm, AOO can not unprotect the > sheet/doc > > >> even user input the right password. To avoid this bad situation, I > guess > > >> the developer disable related function. > > >> > > >> On Wed, Jun 27, 2012 at 3:12 PM, Oliver-Rainer Wittmann < > > >> [email protected]> wrote: > > >> > > >>> Hi, > > >>> > > >>> > > >>> On 26.06.2012 08:44, Jianyuan Li wrote: > > >>> > > >>>> Hi, all, > > >>>> > > >>>> In ../sc/inc/tabprotection.hxx, a macro is defined as below: > > >>>> #define ENABLE_SHEET_PROTECTION 0 > > >>>> > > >>>> So all blocks controlled by it will not be executed: > > >>>> 1. Import/export Sheet/Doc protection password for a protected xls > > file. > > >>>> 2. Import a protected xls file and show unpassword dlg to input > > password > > >>>> when unprotect the sheet/doc. > > >>>> 2. Import a ods/xls file and export it as a xls/ods file. Show > > password > > >>>> retype dlg. > > >>>> And there is an issue related to it: > > >>>> https://issues.apache.org/ooo/**show_bug.cgi?id=119552< > > >> https://issues.apache.org/ooo/show_bug.cgi?id=119552>. > > >>>> I have added some > > >>>> comments for it. > > >>>> I had a simple test to set the macro as 1 and checked all above > > >> scenarios. > > >>>> It works well. So here I want to set the macro as 1. > > >>>> > > >>>> Any comments? Or does anyone know the initial thought for the value > > "0" > > >>>> of ENABLE_SHEET_PROTECTION? > > >>>> > > >>>> > > >>> I do not know anything about this code. > > >>> > > >>> But may be a look in the hg repository - still available at [1] - > would > > >>> help. May be the one or the other commit log message by which this > > macro > > >>> has been introduced would give some answers. > > >>> > > >>> [1] http://hg.services.openoffice.**org/< > > >> http://hg.services.openoffice.org/> > > >>> > > >>> > > >>> Best regards, Oliver. > > >>> > > >> > > > > > > > > > > > > > > > > > > -- > Best regards > Lei De Bin >
