I have reviewed your patch. It looks good. I submitted it. Thanks for your patch.
On Fri, Sep 21, 2012 at 2:29 PM, Clarence GUO <[email protected]>wrote: > HI~ > I have a code review request, > https://issues.apache.org/ooo/show_bug.cgi?id=120962 > This defect is indeed a feature gap. Chart of AOO doesn't support range > name which use a reference formula, not only in UI, but also in core > function and filter. > Although it needs a total solution to make the feature available, I still > want this temporary solution at a bug fix level because it needs some time > to implement the feature. The fix will translate a range name which use a > reference formula to a actural range. So that means after saving, the range > instead of the formula will be saved, the original formula in chart range > will be lost. > > Thanks & BRs > Clarence >
