Sent from my iPad
On Oct 23, 2012, at 2:03 AM, Herbert Duerr <h...@apache.org> wrote: > Hi Andrew, > > On 22.10.2012 20:14, Andrew Rist wrote: >> This was a good try - but >> http://ci.apache.org/builders/aoo-win7/builds/356/steps/compile_1/logs/err.html >> >> will look at it a bit later... > > I saw that you already fixed the missing 's', thanks a lot! > > On a second look I think that using the python string interpolation style > "%(rsync_opts)s" but changed to "%(rsync_opts:-)s" for defaulting to an empty > string could make the script cleaner and more robust. > I think we should use one form or the other consistently. I don't particularly care one way or the other, as long as it is consistent throughout the file. A. > Herbert
