https://issues.apache.org/ooo/show_bug.cgi?id=120108

[email protected] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78507|review?                     |review+
              Flags|                            |

--- Comment #3 from [email protected] ---
Comment on attachment 78507
  --> https://issues.apache.org/ooo/attachment.cgi?id=78507
for file "main/sc/source/ui/view/viewdata.cxx"

Thanks for finding the problem and the solution! Applied as revision 1354849

I apologize for slightly changing the fix because IMHO there is
- no need to check for NULL before delete, especially for stuff that is more
often than not non-NULL
- the code comment did not make the code more clear and the details of the
particular change belong into the revision history, but not into the code. If
every change ever done in a file was commented like that it would become
unreadable

That's only my opinion of course. If you as the author of the fix disagrees
with that I'll reapply it in the original style.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to