https://issues.apache.org/ooo/show_bug.cgi?id=119480

Andre <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #8 from Andre <[email protected]> ---
Your patch looks basically good.

But I still have two questions:

- Regarding the use of atan() on line 4558:
  What do you thing about using atan2() instead?  That would allow detection of
the right quadrant.

- Regarding the call of NormAngle360() on line 4559:
  NormAngle360() seems to expect arguments that are given as angle, measured in
degree*100 (in the range [0,36000) for a full circle).
  In the patch, however, the argument is the result of atan()*100.  Atan()
returns a value in radian (range [-pi/2,+pi/2]).
  Is there a transformation factor missing (radian to degree) or am I missing
something?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to