https://issues.apache.org/ooo/show_bug.cgi?id=120124
Andre <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Andre <[email protected]> --- I have several questions and remarks: - How much faster does saving get with this cache? - There is not much documentation of the new code. Only unnecessary comments that state the issue id, information that is available via svn annotate. Can we get rid of these? - The mnMaxCacheSize is set to an arbitrary magic number of 2800000. Why this number? - The mnMaxCacheSize value is not coordinated with other caches or configurable via Tools->Options - There are two new methods GetUsedCacheSize2() and GetMaxCacheSize2() that just forward the results from their counterparts without the ...2 suffix. Why? - The actual caching logic seems to be the lines in the last hunk of the diff (in sw/source/filter/xml/xmltexte.cxx, lines 229 to 233). They seem to prevent caching of the first created objects that fit into the 2.8MB cache. They will never get swapped in or out. Every object created once the cache is full will always be swapped in or out. That does not look like a good caching strategy and should be improved. -- You are receiving this mail because: You are the assignee for the bug.
