Hi all,
Although we haven't published any formal source code style guidelines
and we don't enforce any coding style, committing code with trailing
whitespace is particularly annoying to me.
I haven't said anything in the past, because the problem has never
really happened.
When code is committed that has a lot of white space only changes it
makes it hard to determine from the svn notice what has really
changed. It makes it hard when using svn diff to tell exactly what
the differences are.
Any decent programmer's editor will have some option for stripping out
trailing white space. If several of the developers use that option,
as most of the current developers do, then the next time one of those
developers makes a small change to the file, the trailing whitespace
will be stripped out, producing another commit message where it is
hard to spot the actual changes.
The current code base contains no, or very very little, trailing
whitespace. I would like to keep it that way. Which of course is why
I'm posting this. <grin>
Not trying to point a finger at any one, or be obnoxious about this,
but if you look at the svn message for commit 7094, at the start of
the ProductView.rex file you see 7 whitespace only changes:
@@ -34,21 +34,26 @@
/* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
/*
*/
/*----------------------------------------------------------------------------*/
-/* ooDialog User Guide
- Exercise 04b: ProductView.rex - The ProductView component
v00-02 28Jly11
-
- Contains: classes "ProductView" and "AboutDialog".
+/* ooDialog User Guide
+ Exercise 04b: ProductView.rex - The ProductView component
v00-03 06Aug11
+
+ Contains: classes "ProductView" and "AboutDialog".
Pre-requisites: ProductView.dll, ProductView.h.
Support\NumberOnlyEditEx.cls (copied from ooDialog Samples)
-
- Description: A sample Product View component - part of the sample
+
+ Description: A sample Product View component - part of the sample
Order Management application.
-
+
Outstanding Problems: None reported.
-
+
The diff has 98 lines where the only change is whitespace added to the
end of the line.
Since this happens to be a file that I'm likely to edit, as soon as I
save the file, there will be another large set of whitespace only
changes. Then if I commit a small 1 line change, it will create a
diff with 99 line changes.
So, I'm sort of formally stating that I would like to see trailing
whitespace stripped before any commit to the source code.
If anyone is using a program editor where they don't know how to
configure it to strip trailing white space on save, I'd be more than
happy to research how to do it with that editor. Just let me know
what the editor is.
--
Mark Miesfeld
------------------------------------------------------------------------------
BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
The must-attend event for mobile developers. Connect with experts.
Get tools for creating Super Apps. See the latest technologies.
Sessions, hands-on labs, demos & much more. Register early & save!
http://p.sf.net/sfu/rim-blackberry-1
_______________________________________________
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel
