Ok, this is fixed now. The test for IntegerZero should not have been done that way. This would only reliably work if the .input stream had not been replaced by another implementation. I've used a more reliable method that will work with any returned object.
Rick On Thu, Mar 15, 2012 at 5:09 AM, Jean-Louis Faucher <[email protected]> wrote: > I continue to review the other failures... > > File: > D:\local\Rexx\ooRexx\svn\test\trunk\ooRexx\base\bif\LINES.testGroup > Line: 176 > Failed: assertSame > Expected: [[0], identityHash="268014444"] > Actual: [[1], identityHash="268001920"] > Message: Non-existent stream, default 2nd arg should return 0 > > This failure below occurs because of the default value passed by > stream_lines in StreamNative.cpp : context->False() > Should be IntegerZero, if i'm not wrong. > > In BuiltinFunctions.cpp, result is not equal to IntegerZero, and we get 1 as > result, hence the failure. > > BUILTIN(LINES) > if (toupper(option->getChar(0)) == 'N') > { > return (result != IntegerZero) ? IntegerOne : IntegerZero; > } > > > I see other failures, all from TIME.testgroup. > Will investigate later, if not done by someone else. > > Jean-Louis > > > 2012/3/14 Rick McGuire <[email protected]> >> >> These failures are not platform specific. I was able to reproduce >> them on Windows just fine. >> >> Rick >> >> On Wed, Mar 14, 2012 at 10:59 AM, Mark Miesfeld <[email protected]> >> wrote: >> > On Wed, Mar 14, 2012 at 7:49 AM, Rick McGuire <[email protected]> >> > wrote: >> >> >> >> Ok, these should be clean now. The circularqueue error was a code >> >> problem, the list and queue failures were errors in the test. The >> >> lines() and chars() failures were due to recent changes, but the other >> >> problems were introduced over a year ago. Is this truly the first >> >> time these have been run against trunk since then? >> > >> > >> > That last is a good question. >> > >> > I periodically run the test suite on Windows, but not on a regular >> > schedule. I'm not on Linux a lot lately so I haven't run the test suite >> > on >> > Linux except for release builds for some time. >> > >> > I guess on Windows I'm mostly using 4.1.0 plus ooDialog 4.2.0, so maybe >> > the >> > last year I've been running the test suite on 4.1.0. >> > >> > But, it seems to me that Enrico (not sure if I have the name right) runs >> > the >> > suite against trunk. Because he has reported some test suite errors. >> > >> > -- >> > Mark Miesfeld >> > >> > >> > >> > ------------------------------------------------------------------------------ >> > Virtualization & Cloud Management Using Capacity Planning >> > Cloud computing makes use of virtualization - but cloud computing >> > also focuses on allowing computing to be delivered as a service. >> > http://www.accelacomm.com/jaw/sfnl/114/51521223/ >> > _______________________________________________ >> > Oorexx-devel mailing list >> > [email protected] >> > https://lists.sourceforge.net/lists/listinfo/oorexx-devel >> > >> >> >> ------------------------------------------------------------------------------ >> Virtualization & Cloud Management Using Capacity Planning >> Cloud computing makes use of virtualization - but cloud computing >> also focuses on allowing computing to be delivered as a service. >> http://www.accelacomm.com/jaw/sfnl/114/51521223/ >> _______________________________________________ >> Oorexx-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/oorexx-devel > > > > ------------------------------------------------------------------------------ > This SF email is sponsosred by: > Try Windows Azure free for 90 days Click Here > http://p.sf.net/sfu/sfd2d-msazure > _______________________________________________ > Oorexx-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/oorexx-devel > ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure _______________________________________________ Oorexx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/oorexx-devel
