> >Erico, this is for sure a great start!!! > > >| I have suggestions that worked for us while packaging ooRexx 4.2.0 that >could be adopted upstream > >I believe we should adopt as much as possible >
Hi Erich, Great! I’ll make sure to present them here first so everybody can check them. > >| 7) There are other simple fixable errors, like wrong linefeeds in a few >.CLS files. >| We used to do a dos2unix on them, but this could be corrected upstream. >| See the logs, they are marked as warnings only. > >I've scanned the ooRexx repository for file with missing eol-style property >and have added eol-style native to those >Not sure if I picked up all .cls files you mentioned. Can you please point >me to one or two logs with those warnings? > Sure. From openSUSE 13.2 build log (https://build.opensuse.org/package/live_build_log/home:emendonca/oorexx5/openSUSE_13.2/x86_64): [ 152s] oorexx.x86_64: W: wrong-script-end-of-line-encoding /usr/share/ooRexx/native.api/tooRecursiveUnhandled.rex [ 152s] oorexx.x86_64: W: wrong-script-end-of-line-encoding /usr/share/ooRexx/usetree.rex [ 152s] oorexx.x86_64: W: wrong-script-end-of-line-encoding /usr/share/ooRexx/native.api/tooRecursiveTrapped.rex [ 152s] oorexx.x86_64: W: wrong-script-end-of-line-encoding /usr/share/ooRexx/native.api/backward.fnc [ 152s] oorexx.x86_64: W: wrong-script-end-of-line-encoding /usr/share/ooRexx/native.api/HelloWorld.rex [ 152s] oorexx.x86_64: W: wrong-script-end-of-line-encoding /usr/bin/csvStream.cls [ 152s] This script has wrong end-of-line encoding, usually caused by creation or [ 152s] modification on a non-Unix system. It will prevent its execution. > >| 5) Check our patch in the original ooRexx 4.2.0 package: >https://build.opensuse.org/package/show/devel:languages:misc/ooRexx >| 8) There is the problem of placing classes in the binary path. >| We solved this with a patch in 4.2.0 that changes the "class path" (see >above) > >Where exactly, on the link you've given, would I find the patch you did? > Here they are (based on 4.2.0): Systemd fixes: https://build.opensuse.org/package/view_file/devel:languages:misc/ooRexx/systemd-fixes.patch?expand=1 Alternate REXX package directory: https://build.opensuse.org/package/view_file/devel:languages:misc/ooRexx/set_default_rexx_path.patch?expand=1 This last patch should place all CLS files in a different path (we chose /usr/share/ooRexx), and avoids such errors like “script-without-shebang” (without an interpreter line at the top, like #!/usr/bin/rexx), and “non-executable-in-bin” (as the CLS files are in /usr/bin). -- — Erico Mendonça Dedicated Support Engineer SUSE ------------------------------------------------------------------------------ Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San Francisco, CA to explore cutting-edge tech and listen to tech luminaries present their vision of the future. This family event has something for everyone, including kids. Get more information and register today. http://sdm.link/attshape _______________________________________________ Oorexx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/oorexx-devel
