Unless there are strong objections, I will open a bug report to document that the incorrect behavior has existed since at least 3.1.2, a fix was attempted for 3.2.0, and the correct behavior is part of 5.0.0. I believe this will help others like myself who "stumble" upon the change to understand the reasons why it has changed. The bug report can be immediately marked as pending.

On 8/16/2016 8:25 PM, Rick McGuire wrote:
This was the original problem that caused me to back things out.

https://sourceforge.net/p/oorexx/bugs/257/

I don't believe there was a bug number or feature request for the final fix.

Rick

On Tue, Aug 16, 2016 at 8:22 PM, Gil Barmwater <[email protected] <mailto:[email protected]>> wrote:

    Would you remember the bug number by any chance?  (I'm not
questioning the fix, just the consequences on existing programs. Having a documented explanation for the "change" will help users
    understand why any code that they wrote that depended on that
    faulty behavior will need to be changed.)


    On 8/16/2016 8:05 PM, Rick McGuire wrote:
    The old behavior was a bug. Because the array class had a
    makestring method, it should have been used for things like say
    and other uses where a string value was required. I won't go into
    the reasons why, but this was never properly implemented. I fixed
    this in (I believe) the 4.0 release, but backed the fix out when
    I discovered the implementation had a problem that could crash
    the interpreter. This problem was fixed in 5.0 and the correct
    behavior was restored.

    Rick

    On Tue, Aug 16, 2016 at 8:02 PM, Gil Barmwater
    <[email protected] <mailto:[email protected]>> wrote:

        I was just playing with the new ooRexx5.0.0 Beta and noticed
        a change in
        behavior.  In earlier releases, the code

        trio = .array~of(1,2,3); say trio

        produced "an Array".  However, in 5.0.0, it produces 3 lines
        containing
        1, 2 and 3 respectively, the same as

        say trio~makeString.

        Reading the documentation it appears the new behavior is the
        correct one
        and the old one was a bug but I didn't find a bug for it in
        the Changes
        document.  So the questions are 1) was this intentional
        (fixing an
        incorrect result) and if so, where is it documented, and 2)
        will this
        change cause old programs to break (quite possibly) and is
        the risk
        acceptable?

        --
        Gil Barmwater


        
------------------------------------------------------------------------------
        _______________________________________________
        Oorexx-devel mailing list
        [email protected]
        <mailto:[email protected]>
        https://lists.sourceforge.net/lists/listinfo/oorexx-devel
        <https://lists.sourceforge.net/lists/listinfo/oorexx-devel>




    
------------------------------------------------------------------------------

    _______________________________________________
    Oorexx-devel mailing list
    [email protected]
    <mailto:[email protected]>
    https://lists.sourceforge.net/lists/listinfo/oorexx-devel
    <https://lists.sourceforge.net/lists/listinfo/oorexx-devel>

-- Gil Barmwater

    
------------------------------------------------------------------------------
    _______________________________________________ Oorexx-devel
    mailing list [email protected]
    <mailto:[email protected]>
    https://lists.sourceforge.net/lists/listinfo/oorexx-devel
<https://lists.sourceforge.net/lists/listinfo/oorexx-devel>
------------------------------------------------------------------------------

_______________________________________________
Oorexx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/oorexx-devel
--
Gil Barmwater
------------------------------------------------------------------------------
_______________________________________________
Oorexx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/oorexx-devel

Reply via email to