Those two SET's were the fix for https://sourceforge.net/p/oorexx/bugs/1577
Specific to CLANG on mac.  That's probably the reason why the mac builds
don't give those c++11 warnings.

There's a new CMake 3.1 set (CMAKE_CXX_STANDARD 11)
And
https://stackoverflow.com/questions/10851247/how-to-activate-c-11-in-cmake
has macro for older-than-3.1 CMakes

On Sun, Jan 13, 2019 at 5:50 PM Rick McGuire <object.r...@gmail.com> wrote:

> Hmm, the following lines in CMakeLists.txt look suspicious. I think the
> SET commands should be outside the conditional.
>
> # Extra link library definitions# gcc (at least on Linux) requires linking 
> with -lcrypt# clang (at least on Darwin) doesn't have libcryptif 
> (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
>     target_link_libraries(rxunixsys rexx rexxapi crypt 
> ${CMAKE_REQUIRED_LIBRARIES})else ()
>     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -stdlib=libc++")
>     set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -stdlib=libc++ 
> -lc++abi")
>
>     target_link_libraries(rxunixsys rexx rexxapi 
> ${CMAKE_REQUIRED_LIBRARIES})endif ()
>
>
> On Sun, Jan 13, 2019 at 11:38 AM Erich Steinböck <
> erich.steinbo...@gmail.com> wrote:
>
>> I only now notice that on our Ubuntu, CentOS and SLES/390 build slaves
>> we're seeing 50000 build warnings of the kind
>>
>> /home/netrexx/workspace/ooRexx-CentOS7-build/rexxapi/client/LocalRegistrationManager.hpp:69:63:
>> warning: override controls (override/final) only available with -std=c++11
>> or -std=gnu++11 [enabled by default]
>>      RexxReturnCode processServiceException(ServiceException *e) override;
>>
>> Guessing from the warning, "override" may be the first c++11 feature
>> we're requiring.
>> I can't say much on how well the c++11 standard is already established on
>> the various Unix systems and Linux distributions.
>>
>>
>> On Sun, Dec 30, 2018 at 10:31 PM Open Object Rexx SVN repository <
>> nore...@code-0.oorexx.p.re.sourceforge.net> wrote:
>>
>>>
>>> Cleanup use of virtual overrides by using the override keyword.
>>>
>>> By bigrixx on 12/30/2018 21:30
>>> [**View Changes**](https://sourceforge.net/p/oorexx/code-0/11653/)
>>>
>>>
>>>
>>>
>>>
>>> ---
>>>
>>> Sent from sourceforge.net because you indicated interest in <
>>> https://sourceforge.net/p/oorexx/code-0/>
>>>
>>>
>>>
>>> To unsubscribe from further messages, please visit <
>>> https://sourceforge.net/auth/subscriptions/>
>>>
>> _______________________________________________
>> Oorexx-devel mailing list
>> Oorexx-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/oorexx-devel
>>
> _______________________________________________
> Oorexx-devel mailing list
> Oorexx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/oorexx-devel
>
_______________________________________________
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel

Reply via email to