more sandbox rexxutil issues:
to remove compiler "warning C4800: 'uint32_t': forcing value to bool 'true'
or 'false' (performance warning)" I believe the following patch should be
appropriate
~~~
--- interpreter/platform/windows/SysRexxUtil.cpp (revision 11717)
+++ interpreter/platform/windows/SysRexxUtil.cpp (working copy)
@@ -793,24 +793,24 @@
return true;
}
- if (!finder->archiveSelected(attr & FILE_ATTRIBUTE_ARCHIVE))
+ if (!finder->archiveSelected((attr & FILE_ATTRIBUTE_ARCHIVE) != 0))
{
return false;
}
// a little silly since this overlaps with the options
- if (!finder->directorySelected(attr & FILE_ATTRIBUTE_DIRECTORY))
+ if (!finder->directorySelected((attr & FILE_ATTRIBUTE_DIRECTORY) != 0))
{
return false;
}
- if (!finder->hiddenSelected(attr & FILE_ATTRIBUTE_HIDDEN))
+ if (!finder->hiddenSelected((attr & FILE_ATTRIBUTE_HIDDEN) != 0))
{
return false;
}
- if (!finder->readOnlySelected(attr & FILE_ATTRIBUTE_READONLY))
+ if (!finder->readOnlySelected((attr & FILE_ATTRIBUTE_READONLY) != 0))
{
return false;
}
- if (!finder->systemSelected(attr & FILE_ATTRIBUTE_SYSTEM))
+ if (!finder->systemSelected((attr & FILE_ATTRIBUTE_SYSTEM) != 0))
{
return false;
}
~~~
call SysWinGetPrinters p.
crashes with runtime debug assertion IsValidHeapPointerBlock failing
rexx -e "a.0 = 1; a.1 = 2; call SysStemSort a.
fails with Error 93.938: Method argument 1 must have a string value.
rexx -e "a.0 = 1; a.1 = 2; call SysStemSort 'a.'
fails with Error 40.921: Argument last ("18446744073709551615") must be
greater than argument first ("1").
SysSearchPath returns the Nullstring even if the file is in the path, e.g.
say SysSearchPath('path', 'rexx.exe')
Array/Stem (removeItem patch and File (lastAccessed commit) tests don't run
because there were trunk changes after you branched sandbox rexxutil.
Do you want to apply those code changes also to your rexxutil branch? Or
will you wait until your branch is merged back in?
When you merge back in, can you please post the exact command with which
you merged? You've given me a link how to merge back some time ago, but I
was unable to make this work when I tried to merge back my oodialog changes
...
Various tests need to be updated because of new error message numbers.
_______________________________________________
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel
