[
https://issues.apache.org/jira/browse/OOZIE-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138746#comment-13138746
]
[email protected] commented on OOZIE-587:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2573/#review2904
-----------------------------------------------------------
Half way done. Yet to review test cases.
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java
<https://reviews.apache.org/r/2573/#comment6485>
The earlier format was more readable.
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java
<https://reviews.apache.org/r/2573/#comment6487>
Can you add comments to describe the purpose of all the queries that you
added?
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java
<https://reviews.apache.org/r/2573/#comment6486>
The old format was better
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java
<https://reviews.apache.org/r/2573/#comment6488>
Succeeded, failed and killed are handled. How about timeout?
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java
<https://reviews.apache.org/r/2573/#comment6489>
Can you check if the debug mode is enabled prior to the call to LOG.debug?
This will save the cost of the argument evaluation.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java
<https://reviews.apache.org/r/2573/#comment6490>
Can you check if the debug mode is enabled prior to the call to LOG.debug?
This will save the cost of the argument evaluation.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java
<https://reviews.apache.org/r/2573/#comment6491>
Can you check if the debug mode is enabled prior to the call to LOG.debug?
This will save the cost of the argument evaluation.
The old format was better.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java
<https://reviews.apache.org/r/2573/#comment6492>
Can you check if the debug mode is enabled prior to the call to LOG.debug?
This will save the cost of the argument evaluation.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java
<https://reviews.apache.org/r/2573/#comment6493>
Can you please move the else back to the same line as the closing
parenthesis? It makes the code more readable.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java
<https://reviews.apache.org/r/2573/#comment6494>
Can you check if the debug mode is enabled prior to the call to LOG.debug?
This will save the cost of the argument evaluation.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java
<https://reviews.apache.org/r/2573/#comment6495>
Can you check if the debug mode is enabled prior to the call to LOG.debug?
This will save the cost of the argument evaluation.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java
<https://reviews.apache.org/r/2573/#comment6497>
Can you check if the debug mode is enabled prior to the call to LOG.debug?
This will save the cost of the argument evaluation.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java
<https://reviews.apache.org/r/2573/#comment6496>
Can you please move the else back to the same line as the closing
parenthesis? It makes the code more readable.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java
<https://reviews.apache.org/r/2573/#comment6498>
Can you check if the debug mode is enabled prior to the call to LOG.debug?
This will save the cost of the argument evaluation.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java
<https://reviews.apache.org/r/2573/#comment6499>
Can you check if the debug mode is enabled prior to the call to LOG.debug?
This will save the cost of the argument evaluation.
The old format was better
trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java
<https://reviews.apache.org/r/2573/#comment6500>
The list instance is called coorActStatus and the hashmap instance is
called coorActionStatus.
Its very hard to figure out the intention of the data structures,
especially when the names are highly similar.
Can you be a bit more descriptive in the variable names?
trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java
<https://reviews.apache.org/r/2573/#comment6501>
Can this be moved back to the previous line?
trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java
<https://reviews.apache.org/r/2573/#comment6502>
This comment is very confusing.
- Santhosh
On 2011-10-27 00:33:57, Virag Kothari wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2573/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-27 00:33:57)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Bug oozie-587
bq. Summary: https://issues.apache.org/jira/browse/OOZIE-587
bq.
bq.
bq. This addresses bug OOZIE-587.
bq. https://issues.apache.org/jira/browse/OOZIE-587
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java
1189491
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java
1189491
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java
1189491
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java
1189491
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java
1189491
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetJPAExecutor.java
1189491
bq.
trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java
1189491
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateStatusJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsRunningJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsStatusByPendingFalseJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSuspendedJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetPendingActionsCountJPAExecutor.java
PRE-CREATION
bq. trunk/release-log.txt 1189491
bq.
bq. Diff: https://reviews.apache.org/r/2573/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added test cases for JPAExecutor. Tested against current test cases.
bq.
bq.
bq. Thanks,
bq.
bq. Virag
bq.
bq.
> Out of memory issues due to current query design
> ------------------------------------------------
>
> Key: OOZIE-587
> URL: https://issues.apache.org/jira/browse/OOZIE-587
> Project: Oozie
> Issue Type: Bug
> Reporter: Virag Kothari
>
> There are services which run at regular intervals (StatusTransitService) and
> loads all the coordinator actions of a job in memory. Also Kill, Suspend and
> Resume commands bring all the coordinators actions of a job in memory. When
> the user had a couple of coordinator jobs each with around 10,000 actions, it
> caused an out of memory issue.
> Solution:
> Only required actions should be brought (through better use of sql seleciton
> and projection operators). "Select *" clause should be avoided unless
> necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
