----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2104/#review2286 -----------------------------------------------------------
release.log and documentation changes are missing. trunk/core/pom.xml <https://reviews.apache.org/r/2104/#comment5266> Why and how these jars are being used? Why only scope at 'test'? trunk/core/pom.xml <https://reviews.apache.org/r/2104/#comment5274> space trunk/core/pom.xml <https://reviews.apache.org/r/2104/#comment5273> space trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java <https://reviews.apache.org/r/2104/#comment5267> I saw you bump up version to 0.9. U might need to change it here. trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java <https://reviews.apache.org/r/2104/#comment5268> and here trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java <https://reviews.apache.org/r/2104/#comment5271> Does MainTestCase use only for Pig testing? If yes, please rename to proper name. trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java <https://reviews.apache.org/r/2104/#comment5270> use static trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java <https://reviews.apache.org/r/2104/#comment5272> space trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java <https://reviews.apache.org/r/2104/#comment5269> The name of method should say what you are testing. - Angelo K. On 2011-10-03 18:59:26, Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2104/ > ----------------------------------------------------------- > > (Updated 2011-10-03 18:59:26) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > OOZIE-564: Embedded pig within python fails when run in oozie > > Summary: > https://issues.apache.org/jira/browse/OOZIE-564 > > > This addresses bug OOZIE-564. > https://issues.apache.org/jira/browse/OOZIE-564 > > > Diffs > ----- > > trunk/core/pom.xml 1178455 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java > 1178455 > trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java > 1178455 > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java > 1178455 > trunk/pom.xml 1178455 > > Diff: https://reviews.apache.org/r/2104/diff > > > Testing > ------- > > Tested against current test cases. New test cases related to embedded pig are > not added > > > Thanks, > > Virag > >
