----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2186/#review2393 -----------------------------------------------------------
/trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java <https://reviews.apache.org/r/2186/#comment5494> The method also has a 'throws IOException' clause /trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java <https://reviews.apache.org/r/2186/#comment5495> InputStream not closed /trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java <https://reviews.apache.org/r/2186/#comment5496> 'continue' is common in if and else blocks, should be at a single place - Virag On 2011-10-05 23:22:06, Angelo K. Huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2186/ > ----------------------------------------------------------- > > (Updated 2011-10-05 23:22:06) > > > Review request for oozie. > > > Summary > ------- > > This is park of work done by Kiran. > > > This addresses bug oozie-26. > https://issues.apache.org/jira/browse/oozie-26 > > > Diffs > ----- > > /trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java 1179033 > /trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java > 1179033 > /trunk/release-log.txt 1179033 > > Diff: https://reviews.apache.org/r/2186/diff > > > Testing > ------- > > > Thanks, > > Angelo K. > >
