----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2273/#review2434 -----------------------------------------------------------
+1, after the following minor changes. trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java <https://reviews.apache.org/r/2273/#comment5527> Additional space can be removed here. trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java <https://reviews.apache.org/r/2273/#comment5528> Additional space to be removed here. trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java <https://reviews.apache.org/r/2273/#comment5529> Additional space to be removed here. trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java <https://reviews.apache.org/r/2273/#comment5530> Additional whitespace to be removed here. trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java <https://reviews.apache.org/r/2273/#comment5531> Additional space to be removed here. trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java <https://reviews.apache.org/r/2273/#comment5532> Additional space to be removed here. trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java <https://reviews.apache.org/r/2273/#comment5533> Additional newline can be removed. trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java <https://reviews.apache.org/r/2273/#comment5534> catch() {} block is empty. adding a throw clause would be better. - params On 2011-10-07 16:49:21, Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2273/ > ----------------------------------------------------------- > > (Updated 2011-10-07 16:49:21) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > This is on behalf of Kiran N.'s work on log retrieval > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java 1175987 > trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 1175987 > trunk/release-log.txt 1175987 > > Diff: https://reviews.apache.org/r/2273/diff > > > Testing > ------- > > > Thanks, > > Mona > >
