----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2386/#review2580 -----------------------------------------------------------
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java <https://reviews.apache.org/r/2386/#comment5779> What is the reason for doubling the wait duration? Can you also add a comment describing the code? http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java <https://reviews.apache.org/r/2386/#comment5780> Why is the wait duration 5 seconds here? Also, can you add a comment describing the code? http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java <https://reviews.apache.org/r/2386/#comment5781> Why is the wait duration 5 seconds here? Also, can you add a comment describing the code? - Santhosh On 2011-10-14 00:15:19, Prakhar Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2386/ > ----------------------------------------------------------- > > (Updated 2011-10-14 00:15:19) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > Test case > TestStatusTransitService::testCoordStatusTransitServiceKilledByUser1() fails > due to race condition between status service and the check assertEquals(true, > coordJob.isPending()). The kill action has already been completed by the time > assertion is checked. > > > This addresses bug OOZIE-581. > https://issues.apache.org/jira/browse/OOZIE-581 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java > 1181872 > > Diff: https://reviews.apache.org/r/2386/diff > > > Testing > ------- > > > Thanks, > > Prakhar > >
