----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2418/#review2637 -----------------------------------------------------------
Ship it! Looks good! +1 - Santhosh On 2011-10-18 00:37:01, Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2418/ > ----------------------------------------------------------- > > (Updated 2011-10-18 00:37:01) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > added error code to signify date range parameter parsing error in particular. > this is handled by CoordinatorEngine when it invokes the function to get > coordinator actions falling in the date range. > > also incorporated feedback in the unit test to improve code readability. > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1185428 > trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1185428 > trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java > 1185428 > > trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java > 1185428 > > Diff: https://reviews.apache.org/r/2418/diff > > > Testing > ------- > > yes > > > Thanks, > > Mona > >
