[
https://issues.apache.org/jira/browse/OOZIE-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143319#comment-13143319
]
[email protected] commented on OOZIE-587:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2573/#review3029
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java
<https://reviews.apache.org/r/2573/#comment6748>
changed to earlier format
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java
<https://reviews.apache.org/r/2573/#comment6749>
comments added
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java
<https://reviews.apache.org/r/2573/#comment6750>
changed to old one
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java
<https://reviews.apache.org/r/2573/#comment6751>
wf job doesn't timeout
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java
<https://reviews.apache.org/r/2573/#comment6752>
Good point.
But the debug statements are virtually in every file. The check whether
debug is enabled or not will reduce readability of code
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java
<https://reviews.apache.org/r/2573/#comment6753>
The current code base has else in the next line. Also the formatter is
designed to put else in the next line.
trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java
<https://reviews.apache.org/r/2573/#comment6754>
confusing variable names removed
trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java
<https://reviews.apache.org/r/2573/#comment6755>
moved
trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java
<https://reviews.apache.org/r/2573/#comment6756>
This is a comment in context.
Can you plz read the comments 5 lines above to understand this comment
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateStatusJPAExecutor.java
<https://reviews.apache.org/r/2573/#comment6757>
removed
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateStatusJPAExecutor.java
<https://reviews.apache.org/r/2573/#comment6758>
extra comment added
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateStatusJPAExecutor.java
<https://reviews.apache.org/r/2573/#comment6759>
comment added
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateStatusJPAExecutor.java
<https://reviews.apache.org/r/2573/#comment6760>
comment added.
Null is requred
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java
<https://reviews.apache.org/r/2573/#comment6761>
english corrected
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java
<https://reviews.apache.org/r/2573/#comment6762>
moved
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java
<https://reviews.apache.org/r/2573/#comment6763>
added
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java
<https://reviews.apache.org/r/2573/#comment6764>
comment added
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java
<https://reviews.apache.org/r/2573/#comment6765>
comment added
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java
<https://reviews.apache.org/r/2573/#comment6766>
comment added
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java
<https://reviews.apache.org/r/2573/#comment6767>
comment added
trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java
<https://reviews.apache.org/r/2573/#comment6768>
pending query is required.
Clarifying comment added
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java
<https://reviews.apache.org/r/2573/#comment6769>
not requried
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java
<https://reviews.apache.org/r/2573/#comment6770>
comments added
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java
<https://reviews.apache.org/r/2573/#comment6771>
not necessary
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java
<https://reviews.apache.org/r/2573/#comment6772>
moved
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java
<https://reviews.apache.org/r/2573/#comment6773>
checked in the test case which checks sql selection operator
- Virag
On 2011-10-31 16:58:25, Virag Kothari wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2573/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-31 16:58:25)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Bug oozie-587
bq. Summary: https://issues.apache.org/jira/browse/OOZIE-587
bq.
bq.
bq. This addresses bug OOZIE-587.
bq. https://issues.apache.org/jira/browse/OOZIE-587
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java
1189491
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java
1189491
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java
1189491
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java
1189491
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java
1189491
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetJPAExecutor.java
1189491
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateStatusJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsRunningJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsStatusByPendingFalseJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSuspendedJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetPendingActionsCountJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java
1189491
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateStatusJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsRunningJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsStatusByPendingFalseJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSuspendedJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetPendingActionsCountJPAExecutor.java
PRE-CREATION
bq. trunk/release-log.txt 1189491
bq.
bq. Diff: https://reviews.apache.org/r/2573/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added test cases for JPAExecutor. Tested against current test cases.
bq.
bq.
bq. Thanks,
bq.
bq. Virag
bq.
bq.
> Out of memory issues due to current query design
> ------------------------------------------------
>
> Key: OOZIE-587
> URL: https://issues.apache.org/jira/browse/OOZIE-587
> Project: Oozie
> Issue Type: Bug
> Reporter: Virag Kothari
>
> There are services which run at regular intervals (StatusTransitService) and
> loads all the coordinator actions of a job in memory. Also Kill, Suspend and
> Resume commands bring all the coordinators actions of a job in memory. When
> the user had a couple of coordinator jobs each with around 10,000 actions, it
> caused an out of memory issue.
> Solution:
> Only required actions should be brought (through better use of sql seleciton
> and projection operators). "Select *" clause should be avoided unless
> necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
