[
https://issues.apache.org/jira/browse/OOZIE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149917#comment-13149917
]
[email protected] commented on OOZIE-480:
-----------------------------------------------------
bq. On 2011-11-14 07:25:55, Mohammad Islam wrote:
bq. > Pls add a release.log entry.
Wouldn't make more sense (as it is done in Hadoop as well) that the committer
edits the release log at commit time?
This would avoid unnecessary conflicts when patches are committed out of order.
bq. On 2011-11-14 07:25:55, Mohammad Islam wrote:
bq. > /trunk/core/src/main/java/org/apache/oozie/service/Services.java, line
284
bq. > <https://reviews.apache.org/r/2802/diff/1/?file=57459#file57459line284>
bq. >
bq. > Although the last one is replacing, the first one is also
initialized (in line 237).
bq. >
bq. > Alternatively, can't we do the replacement before instantiation of
the replaced service class. Wandering if that could create any side-effect.
not possible to do so as we need to instantiate the service to find the
interface it implements.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2802/#review3202
-----------------------------------------------------------
On 2011-11-11 01:32:42, Alejandro Abdelnur wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2802/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-11 01:32:42)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The patch loads all services classes, initializes them to find out the
service interface and keeps the latest one, after that only the final ones are
initialized.
bq.
bq. This will address the problem of the
HadoopAccessorService/KerberosAccessorService
bq.
bq.
bq. This addresses bug OOZIE-480.
bq. https://issues.apache.org/jira/browse/OOZIE-480
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1200683
bq. /trunk/core/src/main/java/org/apache/oozie/service/Services.java 1200683
bq. /trunk/core/src/test/java/org/apache/oozie/service/TestServices.java
1200683
bq.
bq. Diff: https://reviews.apache.org/r/2802/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Alejandro
bq.
bq.
> OOZIE-63: In Oozie-site.xml, if we specify oozie.services.ext property is not
> overriding the services.
> ------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-480
> URL: https://issues.apache.org/jira/browse/OOZIE-480
> Project: Oozie
> Issue Type: Bug
> Reporter: Mayank Bansal
> Assignee: Alejandro Abdelnur
>
> In Oozie-site.xml, if we specify oozie.services.ext property is not
> overriding the services.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
