Chris, Santosh, Thanks for catching those errors, i'll update the docs accordingly.
Alejandro On Sun, Nov 20, 2011 at 11:56 PM, Santhosh Srinivasan <[email protected]> wrote: > On cursory examination: > > <snip> > Coding Conventions > > Oozie uses Java standard coding conventions with the following changes: > > Indentation is 4 spaces instead of 2 spaces. > Maximum line lenght is 132 characters instead of 80 characters. > No @author tags. > </snip> > > There is a typo for length. > I have noticed that the Oozie code does *not* follow the Java convention for > if then else as shown below. > > if (condition) { > ... > } else if (condition) { > ... > } else { > ... > } > > Are we planning to adopt the Java convention going forward? > > Santhosh > > -----Original Message----- > From: Chris Douglas [mailto:[email protected]] > Sent: Friday, November 18, 2011 11:23 AM > To: [email protected] > Subject: Re: How to Contribute > > The "Apache Code Review System" link is broken. -C > > On Fri, Nov 18, 2011 at 8:54 AM, Alejandro Abdelnur <[email protected]> wrote: >> The Oozie site has been updated (thanks for pushing it Mohammad) >> >> Please take 5 mins and read carefully the 'How To Contribute' page >> >> http://incubator.apache.org/oozie/HowToContribute.html >> >> And if you have concerns/corrections please reply to this email, >> otherwise lets start using it as our development guidelines. >> >> Thanks. >> >> Alejandro >> >
