> On 2011-11-24 01:42:37, Angelo K. Huang wrote:
> > /trunk/core/pom.xml, line 225
> > <https://reviews.apache.org/r/2875/diff/2/?file=59621#file59621line225>
> >
> >     why u need log4j at compile?

This is not log4j (which Oozie has already at compile time) but the slf4j log4j 
adapter which is used by Hadoop-auth (alfredo) server side and specified as 
optional dependency in its POM (optional because the client side does not uses 
it).


> On 2011-11-24 01:42:37, Angelo K. Huang wrote:
> > /trunk/core/src/main/resources/oozie-default.xml, line 1407
> > <https://reviews.apache.org/r/2875/diff/2/?file=59625#file59625line1407>
> >
> >     same here

answered in the previous comment.


> On 2011-11-24 01:42:37, Angelo K. Huang wrote:
> > /trunk/core/src/main/conf/oozie-site.xml, line 249
> > <https://reviews.apache.org/r/2875/diff/2/?file=59623#file59623line249>
> >
> >     how to describe Oozie supports multiple auths?

simple & kerberos are aliases for the out of the box supported authentication 
mechanisms. If you have a custom one you specify here the class of your 
AuthenticationHandler. 

How you specify multiple? It is the responsibility fo the AuthenticationHandler 
to do so. You can have an implementation that is a multiplexor of other 
AuthenticationHandlers if you need to. 


> On 2011-11-24 01:42:37, Angelo K. Huang wrote:
> > /trunk/docs/src/site/twiki/AG_Install.twiki, line 200
> > <https://reviews.apache.org/r/2875/diff/2/?file=59628#file59628line200>
> >
> >     Can server supports both at same time?

No with the current implementation, supporting simple and Kerberos at the same 
time does not make sense.

But if you want to support Kerberos and some other (ie) LDAP authentication 
mechanism, then you could write a AuthenticationHandler multiplexor that probes 
the request with the different AuthenticationHandlers it has until one says 
that it validates the request or all fail.


> On 2011-11-24 01:42:37, Angelo K. Huang wrote:
> > /trunk/docs/src/site/twiki/DG_CommandLineTool.twiki, line 92
> > <https://reviews.apache.org/r/2875/diff/2/?file=59629#file59629line92>
> >
> >     We should let user decide what kind of auth he/she wants to use. Ex.
> >     
> >     -auth simple
> >     -auth kerberos

The client does not decide the authentication of the server.

For example, out of the box the client handles both kerberos and simple and it 
will do what the server responds.

If you see the KerberosAuthenticator implementation delegates to the 
SimpleAuthenticator.

If you have a custom mechanism you could do the same, delegating to 
KerberosAuthenticator which in turn will delegate to SimpleAuthenticator.


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2875/#review3498
-----------------------------------------------------------


On 2011-11-21 21:15:10, Alejandro Abdelnur wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2875/
> -----------------------------------------------------------
> 
> (Updated 2011-11-21 21:15:10)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> Using hadoop-auth (Alfredo) 0.23.0.
> 
> Currently using SNAPSHOT because 0.23.0 artifacts have not be published to 
> Apache Maven repo yet.
> 
> 
> This addresses bug OOZIE-77.
>     https://issues.apache.org/jira/browse/OOZIE-77
> 
> 
> Diffs
> -----
> 
>   /trunk/client/pom.xml 1204710 
>   /trunk/client/src/main/bin/oozie 1204710 
>   /trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1204710 
>   /trunk/client/src/main/java/org/apache/oozie/client/AuthOozieClient.java 
> PRE-CREATION 
>   /trunk/core/pom.xml 1204710 
>   /trunk/core/src/main/conf/oozie-log4j.properties 1204710 
>   /trunk/core/src/main/conf/oozie-site.xml 1204710 
>   /trunk/core/src/main/java/org/apache/oozie/servlet/AuthFilter.java 
> PRE-CREATION 
>   /trunk/core/src/main/resources/oozie-default.xml 1204710 
>   /trunk/core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 
> 1204710 
>   
> /trunk/core/src/test/java/org/apache/oozie/servlet/TestAuthFilterAuthOozieClient.java
>  PRE-CREATION 
>   /trunk/docs/src/site/twiki/AG_Install.twiki 1204710 
>   /trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1204710 
>   /trunk/pom.xml 1204710 
>   /trunk/webapp/pom.xml 1204710 
>   /trunk/webapp/src/main/webapp/WEB-INF/web.xml 1204710 
> 
> Diff: https://reviews.apache.org/r/2875/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alejandro
> 
>

Reply via email to