[ 
https://issues.apache.org/jira/browse/OOZIE-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160979#comment-13160979
 ] 

[email protected] commented on OOZIE-156:
-----------------------------------------------------



bq.  On 2011-12-01 10:15:41, Mohammad Islam wrote:
bq.  > /trunk/client/src/main/resources/sqoop-action-0.2.xsd, line 58
bq.  > <https://reviews.apache.org/r/2972/diff/1/?file=60676#file60676line58>
bq.  >
bq.  >     why move is not supported?

same as the prepare for all other actions, we are currently not supporting move 
there.


bq.  On 2011-12-01 10:15:41, Mohammad Islam wrote:
bq.  > /trunk/core/pom.xml, line 623
bq.  > <https://reviews.apache.org/r/2972/diff/1/?file=60677#file60677line623>
bq.  >
bq.  >     is this the only supported hadoop version? Will it work for any 
apache version?

It will work with an apache version 0.23 onwards.  


bq.  On 2011-12-01 10:15:41, Mohammad Islam wrote:
bq.  > 
/trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java,
 line 124
bq.  > <https://reviews.apache.org/r/2972/diff/1/?file=60680#file60680line124>
bq.  >
bq.  >     why does it return hive?

thanks for catching this. will fix.


bq.  On 2011-12-01 10:15:41, Mohammad Islam wrote:
bq.  > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java, 
line 78
bq.  > <https://reviews.apache.org/r/2972/diff/1/?file=60681#file60681line78>
bq.  >
bq.  >     is it really hive-site.xml ?

no, have to remove this, will fix.


bq.  On 2011-12-01 10:15:41, Mohammad Islam wrote:
bq.  > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java, 
line 81
bq.  > <https://reviews.apache.org/r/2972/diff/1/?file=60681#file60681line81>
bq.  >
bq.  >     please use try {}finally {os.close()}
bq.  >     Same thing in multiple places of this file.

k


bq.  On 2011-12-01 10:15:41, Mohammad Islam wrote:
bq.  > /trunk/docs/src/site/twiki/DG_SqoopActionExtension.twiki, line 62
bq.  > <https://reviews.apache.org/r/2972/diff/1/?file=60683#file60683line62>
bq.  >
bq.  >     </sqoop> --></command>

will fix


bq.  On 2011-12-01 10:15:41, Mohammad Islam wrote:
bq.  > /trunk/docs/src/site/twiki/index.twiki, line 59
bq.  > <https://reviews.apache.org/r/2972/diff/1/?file=60685#file60685line59>
bq.  >
bq.  >      extra line?

k


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2972/#review3592
-----------------------------------------------------------


On 2011-11-29 23:23:25, Alejandro Abdelnur wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2972/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-11-29 23:23:25)
bq.  
bq.  
bq.  Review request for oozie.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Adding sqoop action
bq.  
bq.  
bq.  This addresses bug OOZIE-156.
bq.      https://issues.apache.org/jira/browse/OOZIE-156
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1208129 
bq.    /trunk/client/src/main/resources/sqoop-action-0.2.xsd PRE-CREATION 
bq.    /trunk/core/pom.xml 1208129 
bq.    /trunk/core/src/main/conf/oozie-site.xml 1208129 
bq.    
/trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceMain.java 
1208129 
bq.    
/trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java
 PRE-CREATION 
bq.    /trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java 
PRE-CREATION 
bq.    
/trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java
 PRE-CREATION 
bq.    /trunk/docs/src/site/twiki/DG_SqoopActionExtension.twiki PRE-CREATION 
bq.    /trunk/docs/src/site/twiki/ENG_Building.twiki 1208129 
bq.    /trunk/docs/src/site/twiki/index.twiki 1208129 
bq.    /trunk/examples/pom.xml 1208129 
bq.    /trunk/examples/src/main/apps/sqoop-freeform/db.hsqldb.properties 
PRE-CREATION 
bq.    /trunk/examples/src/main/apps/sqoop-freeform/db.hsqldb.script 
PRE-CREATION 
bq.    /trunk/examples/src/main/apps/sqoop-freeform/job.properties PRE-CREATION 
bq.    /trunk/examples/src/main/apps/sqoop-freeform/workflow.xml PRE-CREATION 
bq.    /trunk/examples/src/main/apps/sqoop/db.hsqldb.properties PRE-CREATION 
bq.    /trunk/examples/src/main/apps/sqoop/db.hsqldb.script PRE-CREATION 
bq.    /trunk/examples/src/main/apps/sqoop/job.properties PRE-CREATION 
bq.    /trunk/examples/src/main/apps/sqoop/workflow.xml PRE-CREATION 
bq.    /trunk/pom.xml 1208129 
bq.    /trunk/sharelib/pom.xml 1208129 
bq.    /trunk/sharelib/sqoop/pom.xml PRE-CREATION 
bq.    /trunk/src/main/assemblies/sharelib.xml 1208129 
bq.  
bq.  Diff: https://reviews.apache.org/r/2972/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Similar to the hive action, a special profile must be used to run the 
sqoop action testcase:
bq.  
bq.  $ mvn clean test -DtestSqoop -Dtest=TestSqoopActionExecutor
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Alejandro
bq.  
bq.


                
> Add support for a SQOOP action
> ------------------------------
>
>                 Key: OOZIE-156
>                 URL: https://issues.apache.org/jira/browse/OOZIE-156
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Hadoop QA
>            Assignee: Alejandro Abdelnur
>         Attachments: OOZIE-156v1.patch, OOZIE-156v2.patch
>
>
> Original issue: GH-139

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to