[
https://issues.apache.org/jira/browse/OOZIE-621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162628#comment-13162628
]
[email protected] commented on OOZIE-621:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2948/#review3614
-----------------------------------------------------------
A few more comments to change the error message and the related unit test cases.
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/2948/#comment8069>
Change Numerical to numerical. Will require changes to your test case too.
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/2948/#comment8066>
Valid value is one of months, days, hours or minutes. Change your unit test
case too.
trunk/core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java
<https://reviews.apache.org/r/2948/#comment8067>
Any reason for postincrementing index?
trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java
<https://reviews.apache.org/r/2948/#comment8068>
Test specifying the value for unit but leaving out the value for frequency
- Santhosh
On 2011-12-01 20:55:19, Kiran Nagasubramanian wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2948/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-01 20:55:19)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. While specifying frequency value as part of -filter command option, it
should be possible to specify the timeunit also.
bq.
bq.
bq. This addresses bug OOZIE-621.
bq. https://issues.apache.org/jira/browse/OOZIE-621
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java
1205116
bq. trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1205116
bq. trunk/core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java
1205116
bq. trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java
1205116
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java
1205116
bq. trunk/release-log.txt 1205116
bq.
bq. Diff: https://reviews.apache.org/r/2948/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Kiran
bq.
bq.
> Option to add timeunit for frequency for coordinator job log filtering
> ----------------------------------------------------------------------
>
> Key: OOZIE-621
> URL: https://issues.apache.org/jira/browse/OOZIE-621
> Project: Oozie
> Issue Type: Improvement
> Reporter: Kiran Nagasubramanian
>
> While specifying frequency value as part of -filter command option, it should
> be possible to specify the timeunit also. The timeunit can take one of the
> following four values: months, days, hours or minutes, all being case
> sensitive. Find the example below:
> oozie jobs -jobtype coord -filter frequency=60;unit=minutes
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
