----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3021/#review3680 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java <https://reviews.apache.org/r/3021/#comment8192> instead having multiple returns through the method, use a local variable and if/else blocks and have a single return at the end of the method. (it is much easier to follow the logic then) trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java <https://reviews.apache.org/r/3021/#comment8193> don't write to STDERR, use LOG trunk/release-log.txt <https://reviews.apache.org/r/3021/#comment8191> patch should not edit release-log.txt, this ought to be done by the committer - Alejandro On 2011-12-06 03:34:49, Kiran Nagasubramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3021/ > ----------------------------------------------------------- > > (Updated 2011-12-06 03:34:49) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > When retrieving the log content from compressed log files(gzip format), > unexpected exceptions are raised when file names dont conform to the standard > format.Those exceptions need to be handled gracefully. > > > This addresses bug OOZIE-627. > https://issues.apache.org/jira/browse/OOZIE-627 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java 1210717 > trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 1210717 > trunk/release-log.txt 1210717 > > Diff: https://reviews.apache.org/r/3021/diff > > > Testing > ------- > > Yes > > > Thanks, > > Kiran > >
