[
https://issues.apache.org/jira/browse/OOZIE-563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164096#comment-13164096
]
[email protected] commented on OOZIE-563:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3043/#review3692
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
<https://reviews.apache.org/r/3043/#comment8217>
is there any reason you re-order the two statement.
it seems logging the message doesn't depend on checking input. Are you
intending to add the status to the log message
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
<https://reviews.apache.org/r/3043/#comment8216>
it seems the for loop is overloaded here and makes the code not very
readable. You may iterate through the list and check for the existence of the
path during the iteration and do right action accordingly
As well, the variable allExists is not right as it given the impression you
are checking for the existence of all the paths which is not correct.
I believe the code need to be re-written on a more simpler and readable way.
as well based on this implementation, you only returning the status of the
last path. so if all the previous paths exist but the last one in non-exist.
you will return false.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java
<https://reviews.apache.org/r/3043/#comment8218>
overloading the index of different meanings looks confusing. you may get
red of the index and use actualMissDeps in the if statement
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java
<https://reviews.apache.org/r/3043/#comment8219>
which dependency ... you may include the missing dependency in the error
message
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java
<https://reviews.apache.org/r/3043/#comment8220>
same as before
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java
<https://reviews.apache.org/r/3043/#comment8221>
same as before
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java
<https://reviews.apache.org/r/3043/#comment8222>
same as before. spill out the missed dependency
- Mohamed
On 2011-12-07 02:05:15, Mona Chitnis wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3043/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-07 02:05:15)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The "Missing Dependencies" for any coordinator action lists all the
dependencies after first dependency is missing. Even though the subsequent
dependencies are present. This patch is a small correction to ensure only the
data dependencies which are not ready/resolved are added to the "Missing
Dependencies" list.
bq.
bq.
bq. This addresses bug OOZIE-563.
bq. https://issues.apache.org/jira/browse/OOZIE-563
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java
1211247
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
1211247
bq.
bq. Diff: https://reviews.apache.org/r/3043/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. yes
bq.
bq.
bq. Thanks,
bq.
bq. Mona
bq.
bq.
> Missing dependency showing feeds that are already present
> ---------------------------------------------------------
>
> Key: OOZIE-563
> URL: https://issues.apache.org/jira/browse/OOZIE-563
> Project: Oozie
> Issue Type: Bug
> Reporter: Mona Chitnis
> Priority: Minor
> Labels: oozie
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> oozie job -info 12345-oozie-wf-Z@3
> ID : 12345-oozie-wf-Z@3
> ------------------------------------------------------------------------------------------------------------------------------------
> Action Number : 3
> Console URL : -
> Error Code : -
> Error Message : -
> External ID : -
> External Status : -
> Job ID : 12345-oozie-wf-Z
> Tracker URI : -
> Created : 2011-07-28 05:45
> Nominal Time : 2011-05-28 00:14
> Status : WAITING
> Last Modified : 2011-07-28 06:11
> Missing Dependencies :
> hdfs://$namenode:8020/user/$username/input/input_hdfs_auth/2011/05/28/00/13/_SUCCESS#hdfs://$namenode:8020/user/$username/input/input_hdfs_auth/2011/05/28/00/12/_SUCCESS#hdfs://$namenode:8020/user/$username/input/input_hdfs_auth/2011/05/28/00/11/_SUCCESS#hdfs://$namenode:8020/user/$username/input/input_hdfs_auth/2011/05/28/00/10/_SUCCESS
> -----------------------------------------------------------------------------
> The 'Missing Dependencies" is misleading for users.
> The "Missing Dependencies" shows all the dependencies after first dependency
> is missing. Even though
> following dependencies are present.
> Is it feasible to show only the first missing dependency or only missing
> dependencies?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
