[
https://issues.apache.org/jira/browse/OOZIE-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164649#comment-13164649
]
[email protected] commented on OOZIE-628:
-----------------------------------------------------
bq. On 2011-12-06 22:31:44, Alejandro Abdelnur wrote:
bq. > Please test building a distribution and running the examples as
testcases don't test actual sharelib usage (the JARs are in the testclasspath
already)
ok
bq. On 2011-12-06 22:31:44, Alejandro Abdelnur wrote:
bq. >
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java,
line 437
bq. > <https://reviews.apache.org/r/3039/diff/1/?file=62631#file62631line437>
bq. >
bq. > the action sharelib should be added outside of this method.
ok
bq. On 2011-12-06 22:31:44, Alejandro Abdelnur wrote:
bq. >
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java,
line 438
bq. > <https://reviews.apache.org/r/3039/diff/1/?file=62631#file62631line438>
bq. >
bq. > is the oozie sharelib always added and the action sharelibs only if
the USE_SYSTEM_LIBPATH is set?
bq. >
bq. > this is kind of confusing.
Yes, Oozie Sharelibs which are common to all actions will always be added.
Action share libs will only be added if use_system_libpath is set to true.
bq. On 2011-12-06 22:31:44, Alejandro Abdelnur wrote:
bq. >
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java,
line 428
bq. > <https://reviews.apache.org/r/3039/diff/1/?file=62631#file62631line428>
bq. >
bq. > this is not an actionsharelib, the method should be renamed to
addShareLib
ok
bq. On 2011-12-06 22:31:44, Alejandro Abdelnur wrote:
bq. >
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java,
line 425
bq. > <https://reviews.apache.org/r/3039/diff/1/?file=62631#file62631line425>
bq. >
bq. > The JIRA states that action JARs have precedence over the oozie lib
JARs but the logic here is the other way around.
good catch, will change the logic
- Virag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3039/#review3677
-----------------------------------------------------------
On 2011-12-06 22:15:07, Virag Kothari wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3039/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-06 22:15:07)
bq.
bq.
bq. Review request for oozie, Mohammad Islam, Angelo K. Huang, and Alejandro
Abdelnur.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Add libraries which can be used by all actions in oozie
bq.
bq. https://issues.apache.org/jira/browse/OOZIE-628
bq.
bq.
bq. This addresses bug OOZIE-628.
bq. https://issues.apache.org/jira/browse/OOZIE-628
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
1211066
bq. trunk/release-log.txt 1211066
bq.
bq. Diff: https://reviews.apache.org/r/3039/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested against current test cases
bq.
bq.
bq. Thanks,
bq.
bq. Virag
bq.
bq.
> Add libraries which can be used by all actions in oozie
> -------------------------------------------------------
>
> Key: OOZIE-628
> URL: https://issues.apache.org/jira/browse/OOZIE-628
> Project: Oozie
> Issue Type: Improvement
> Reporter: Virag Kothari
>
> In Oozie - 610, action specific share libs are added. This JIRA proposes an
> enhancement to it where libraries are added which can be shared by all
> actions.
> For e.g, I am modifying Pig to store the stats. But Json library is required
> to do so. By putting the json lib at a common location, other actions like
> hive, distcp can use this library in future.
> For e.g, all common libs can be stored in
> /share/lib/oozie/*
> Also, all action specific share libs will override the common libs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
