----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3047/#review3724 -----------------------------------------------------------
Ship it! +1 - Prakhar On 2011-12-07 23:53:52, params wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3047/ > ----------------------------------------------------------- > > (Updated 2011-12-07 23:53:52) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > OOZIE-588: Oozie to allow drill down to hadoop job's details > > Summary: > https://issues.apache.org/jira/browse/OOZIE-588 > > Features Implemented: > - Expose action stats information (hadoop counters and pig stats) through CLI > -info -verbose option > - Expose external child IDs (eg: hadoop job IDs for the pig action) through > CLI -info -verbose option > - Expose job counter info as EL Functions > - Expose external child IDs as EL Functions > - User level configuration to specify if stats should be collected or not > (with a default setting) > - Oozie level configuration to specify the max allowable size for stats > > > This addresses bug OOZIE-588. > https://issues.apache.org/jira/browse/OOZIE-588 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1211308 > trunk/client/src/main/java/org/apache/oozie/client/WorkflowAction.java > 1211308 > trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java > 1211308 > trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java > 1211308 > trunk/core/src/main/java/org/apache/oozie/DagELFunctions.java 1211308 > trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1211308 > trunk/core/src/main/java/org/apache/oozie/action/ActionExecutor.java > 1211308 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/ActionStats.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/action/hadoop/ActionType.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/action/hadoop/MRStats.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java > 1211308 > > trunk/core/src/main/java/org/apache/oozie/client/rest/JsonWorkflowAction.java > 1211308 > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCommand.java > 1211308 > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java > 1211308 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetJPAExecutor.java > 1211308 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionSubsetGetJPAExecutor.java > 1211308 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsGetForJobJPAExecutor.java > 1211308 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsRunningGetJPAExecutor.java > 1211308 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetActionsJPAExecutor.java > 1211308 > trunk/core/src/main/java/org/apache/oozie/store/WorkflowStore.java 1211308 > trunk/core/src/test/java/org/apache/oozie/TestActionBean.java 1211308 > > trunk/core/src/test/java/org/apache/oozie/action/decision/TestDecisionActionExecutor.java > 1211308 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java > 1211308 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java > 1211308 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java > 1211308 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java > 1211308 > > trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutor.java > 1211308 > > trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowAction.java > 1211308 > > Diff: https://reviews.apache.org/r/3047/diff > > > Testing > ------- > > - Tested against existing test cases and added tests where required. > - Tests for the new classes MRStats and OoziePigStats have not been added. > This is work in progress. > > > Thanks, > > params > >
