> On 2011-12-05 06:48:56, Santhosh Srinivasan wrote: > > trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java, > > line 130 > > <https://reviews.apache.org/r/2997/diff/1/?file=61775#file61775line130> > > > > Can you move the else back to the previous line to conform with Java > > coding convention?
done. Oozie formatting introduces this change. We need to update the formatter > On 2011-12-05 06:48:56, Santhosh Srinivasan wrote: > > trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java, > > line 143 > > <https://reviews.apache.org/r/2997/diff/1/?file=61775#file61775line143> > > > > Semantics are preserved. done > On 2011-12-05 06:48:56, Santhosh Srinivasan wrote: > > trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java, > > line 145 > > <https://reviews.apache.org/r/2997/diff/1/?file=61775#file61775line145> > > > > I did not quite understand how iterating over populating a new > > configuration with the entries in the conf is solving the problem. Can you > > please explain? addressed as comments above the code change > On 2011-12-05 06:48:56, Santhosh Srinivasan wrote: > > trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java, > > line 67 > > <https://reviews.apache.org/r/2997/diff/1/?file=61776#file61776line67> > > > > Can you please add comments on how the re-run code is being tested fore > > replacing the job.properties values? testcase updated for clarity - Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2997/#review3615 ----------------------------------------------------------- On 2011-12-08 01:18:05, Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2997/ > ----------------------------------------------------------- > > (Updated 2011-12-08 01:18:05) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > In workflow rerun, parametrized variables were not getting replaced with > values in the action configuration, causing a JA018 error. Therefore it is > required to have the action configuration in the rerun code to update itself > with the values corresponding to the keys. > > > This addresses bug OOZIE-8. > https://issues.apache.org/jira/browse/OOZIE-8 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java > 1210771 > trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java > 1210771 > trunk/core/src/test/resources/rerun-varsub-wf.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/2997/diff > > > Testing > ------- > > yes > > > Thanks, > > Mona > >
