[
https://issues.apache.org/jira/browse/OOZIE-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164990#comment-13164990
]
[email protected] commented on OOZIE-624:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3069/#review3732
-----------------------------------------------------------
Looks good
Few questions/comments/recommendations
/trunk/client/src/main/java/org/apache/oozie/client/AuthOozieClient.java
<https://reviews.apache.org/r/3069/#comment8389>
why you want to print the tokens ?
/trunk/client/src/main/java/org/apache/oozie/client/AuthOozieClient.java
<https://reviews.apache.org/r/3069/#comment8393>
Typo .. instantiated .
/trunk/client/src/main/java/org/apache/oozie/client/AuthOozieClient.java
<https://reviews.apache.org/r/3069/#comment8396>
change the header to reflect the newly added authentication
as well add the new exception you are currently throwing ..
[IllegalArgumentException]
/trunk/client/src/main/java/org/apache/oozie/client/AuthOozieClient.java
<https://reviews.apache.org/r/3069/#comment8394>
this piece of code needs to be simplified ...
a switch statement may be more suitable here
return (authType ==AuthType.KERBEROS) ? new KerberosAuthenticator() : new
PseudoAuthenticator();
you already checked for the type while getting the type of authType ..
/trunk/client/src/main/java/org/apache/oozie/client/AuthOozieClient.java
<https://reviews.apache.org/r/3069/#comment8395>
catching a generic exception is not always good programming practice..
it is better to spill out the type of exceptions you may need to catch
/trunk/core/src/main/conf/oozie-site.xml
<https://reviews.apache.org/r/3069/#comment8388>
extra tab
- Mohamed
On 2011-12-08 02:52:04, Angelo K. Huang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3069/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-08 02:52:04)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This improvement is mainly to add client parameter options to handle user
specified authentication option. In Oozie-77, client authentication uses
fall-back strategy to handle authentication, such as kerberos -> simple. User
should allow to give parameter or property to specify which authentication to
use.
bq.
bq. A proposal is :
bq.
bq. -auth simple
bq. -auth kerberos
bq. -auth <auth_name>
bq.
bq.
bq. This addresses bug OOZIE-624.
bq. https://issues.apache.org/jira/browse/OOZIE-624
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1209346
bq. /trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1209346
bq. /trunk/core/src/main/conf/oozie-site.xml 1209346
bq. /trunk/client/src/main/java/org/apache/oozie/client/AuthOozieClient.java
1209346
bq.
bq. Diff: https://reviews.apache.org/r/3069/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Angelo K.
bq.
bq.
> client side improvement of authentication for user defined options
> ------------------------------------------------------------------
>
> Key: OOZIE-624
> URL: https://issues.apache.org/jira/browse/OOZIE-624
> Project: Oozie
> Issue Type: Improvement
> Reporter: Angelo K. Huang
> Assignee: Angelo K. Huang
> Labels: authentication, hadoop, oozie
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> This improvement is mainly to add client parameter options to handle user
> specified authentication option. In Oozie-77, client authentication uses
> fall-back strategy to handle authentication, such as kerberos -> simple. User
> should allow to give parameter or property to specify which authentication to
> use.
> A proposal is :
> -auth simple
> -auth kerberos
> -auth <auth_name>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
