----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3068/#review3730 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java <https://reviews.apache.org/r/3068/#comment8385> Initialization to null is not required. By default, objects are initialized to null. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java <https://reviews.apache.org/r/3068/#comment8381> A couple of comments: 1. Why are you not throwing CoordinatorJobException? 2. The error message has to be more informative. Please include the givenInstance to help the user identify the source of the problem. Additional information about why parsing failed will make it complete. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java <https://reviews.apache.org/r/3068/#comment8382> Based on changes to the error message, the check here has to change. - Santhosh On 2011-12-07 22:58:35, Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3068/ > ----------------------------------------------------------- > > (Updated 2011-12-07 22:58:35) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > Oozie server uses a system configurable property to define the default > dataset initial-instance, i.e., UTC 1970-01-01T00:00Z. > > Oozie will prevent launching job that mentions any dataset initial instance > earlier than the system default (e.g. 1970-01-01T00:00Z). Firstly it makes > for good sanity check, and secondly it will avoid the situation where it > takes a really long time to compute and resolve dataset instances if the date > is older than the above default one - the oldest date permitted. > > > This addresses bug OOZIE-629. > https://issues.apache.org/jira/browse/OOZIE-629 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 1211626 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java > 1211626 > > Diff: https://reviews.apache.org/r/3068/diff > > > Testing > ------- > > yes > > > Thanks, > > Mona > >
