[
https://issues.apache.org/jira/browse/OOZIE-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165749#comment-13165749
]
[email protected] commented on OOZIE-627:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3021/#review3764
-----------------------------------------------------------
Comments for formatting and readability.
trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java
<https://reviews.apache.org/r/3021/#comment8505>
Please move the catch to the previous line
trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java
<https://reviews.apache.org/r/3021/#comment8506>
Add the else to make the code safe, i.e., } else { returnVal = -1; }
trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java
<https://reviews.apache.org/r/3021/#comment8503>
Please move the catch to the previous line
trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java
<https://reviews.apache.org/r/3021/#comment8504>
Please move the catch to the previous line
trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java
<https://reviews.apache.org/r/3021/#comment8513>
Can you add a comment here about why the date range specified in the
argument list is important, i.e., what are you testing?
trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java
<https://reviews.apache.org/r/3021/#comment8512>
Please change the comment to indicate the semantics of the check. Is the
check for the inclusion or exclusion of the .bz2.gz file?
trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java
<https://reviews.apache.org/r/3021/#comment8514>
Can you add a comment here about why the use of null for start and end time
is important? Based on my code browse, startTime will be set to 0 and end time
will be set to current time. What are the implications of these values?
trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java
<https://reviews.apache.org/r/3021/#comment8515>
Please change the comment to indicate the semantics of the check. Is the
check for the inclusion or exclusion of the .bz2.gz file?
- Santhosh
On 2011-12-08 22:38:29, Kiran Nagasubramanian wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3021/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-08 22:38:29)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. When retrieving the log content from compressed log files(gzip format),
unexpected exceptions are raised when file names dont conform to the standard
format.Those exceptions need to be handled gracefully.
bq.
bq.
bq. This addresses bug OOZIE-627.
bq. https://issues.apache.org/jira/browse/OOZIE-627
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java 1210717
bq. trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java
1210717
bq.
bq. Diff: https://reviews.apache.org/r/3021/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Yes
bq.
bq.
bq. Thanks,
bq.
bq. Kiran
bq.
bq.
> Handle GZ log retrieval failures gracefully
> -------------------------------------------
>
> Key: OOZIE-627
> URL: https://issues.apache.org/jira/browse/OOZIE-627
> Project: Oozie
> Issue Type: Improvement
> Reporter: Kiran Nagasubramanian
>
> When retrieving the log content from compressed log files(gzip format),
> unexpected exceptions are raised when file names dont conform to the standard
> format.Those exceptions need to be handled gracefully.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
