----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3059/#review3765 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/3059/#comment8508> private I do not understand why this needs to be a constant value? trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/3059/#comment8507> private static final trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/3059/#comment8511> java doc format and parameters /** */ trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java <https://reviews.apache.org/r/3059/#comment8510> java doc trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java <https://reviews.apache.org/r/3059/#comment8509> java doc trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java <https://reviews.apache.org/r/3059/#comment8516> java doc trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java <https://reviews.apache.org/r/3059/#comment8517> java doc trunk/core/src/main/java/org/apache/oozie/action/hadoop/OoziePigStats.java <https://reviews.apache.org/r/3059/#comment8518> move after java doc trunk/core/src/main/java/org/apache/oozie/action/hadoop/OoziePigStats.java <https://reviews.apache.org/r/3059/#comment8519> you use comment for java doc. java doc format is /** */ trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java <https://reviews.apache.org/r/3059/#comment8520> java doc trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java <https://reviews.apache.org/r/3059/#comment8521> private static final trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java <https://reviews.apache.org/r/3059/#comment8522> do you want to do this to keep stacktrace? throw new UnsupportedOperationException( 307 "Pig stats are not supported for this type of operation", uoe); trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java <https://reviews.apache.org/r/3059/#comment8523> does it need to be static? trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java <https://reviews.apache.org/r/3059/#comment8525> java doc trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java <https://reviews.apache.org/r/3059/#comment8526> java doc trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java <https://reviews.apache.org/r/3059/#comment8535> identation - Angelo K. On 2011-12-08 08:54:20, Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3059/ > ----------------------------------------------------------- > > (Updated 2011-12-08 08:54:20) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > This patch and https://reviews.apache.org/r/3047/diff addresses Oozie-588 > > > Docs for how to access pig stats through el functions needs to be added > > > This addresses bug Oozie-588. > https://issues.apache.org/jira/browse/Oozie-588 > > > Diffs > ----- > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java > 1211573 > trunk/core/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java > 1211573 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 1211573 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java > 1211573 > trunk/core/src/main/resources/oozie-default.xml 1211573 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java > 1211573 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java > 1211573 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > 1211573 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/OoziePigStats.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1211573 > > Diff: https://reviews.apache.org/r/3059/diff > > > Testing > ------- > > Test cases for PigMain and PigAE added > Tested pig action after running examples > > > Thanks, > > Virag > >
