[
https://issues.apache.org/jira/browse/OOZIE-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165816#comment-13165816
]
[email protected] commented on OOZIE-629:
-----------------------------------------------------
bq. On 2011-12-08 05:35:44, Santhosh Srinivasan wrote:
bq. >
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java,
line 724
bq. > <https://reviews.apache.org/r/3068/diff/1/?file=63040#file63040line724>
bq. >
bq. > Initialization to null is not required. By default, objects are
initialized to null.
done
bq. On 2011-12-08 05:35:44, Santhosh Srinivasan wrote:
bq. >
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java,
line 732
bq. > <https://reviews.apache.org/r/3068/diff/1/?file=63040#file63040line732>
bq. >
bq. > A couple of comments:
bq. > 1. Why are you not throwing CoordinatorJobException?
bq. >
bq. > 2. The error message has to be more informative. Please include the
givenInstance to help the user identify the source of the problem. Additional
information about why parsing failed will make it complete.
1. This failure should be treated separately as this is caused by parsing error
of the date and the other case we are testing for is comparison with a date in
correct format. Throwing IllegalArgumentException here gets bubbled up as
ErrorCode.1003 - invalid coordinator application attributes, which is more apt
for the string that has parsing error. This will show the difference from
CoordinatorJobException thrown by the comparison block which bubbles up as
ErrorCode.1021. In both cases, the job is failed and does not get submitted.
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3068/#review3730
-----------------------------------------------------------
On 2011-12-07 22:58:35, Mona Chitnis wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3068/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-07 22:58:35)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Oozie server uses a system configurable property to define the default
dataset initial-instance, i.e., UTC 1970-01-01T00:00Z.
bq.
bq. Oozie will prevent launching job that mentions any dataset initial
instance earlier than the system default (e.g. 1970-01-01T00:00Z). Firstly it
makes for good sanity check, and secondly it will avoid the situation where it
takes a really long time to compute and resolve dataset instances if the date
is older than the above default one - the oldest date permitted.
bq.
bq.
bq. This addresses bug OOZIE-629.
bq. https://issues.apache.org/jira/browse/OOZIE-629
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
1211626
bq.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java
1211626
bq.
bq. Diff: https://reviews.apache.org/r/3068/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. yes
bq.
bq.
bq. Thanks,
bq.
bq. Mona
bq.
bq.
> Oozie server to prevent usage of dataset initial-instance earlier than the
> system-defined default value
> -------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-629
> URL: https://issues.apache.org/jira/browse/OOZIE-629
> Project: Oozie
> Issue Type: Bug
> Reporter: Mona Chitnis
> Priority: Minor
> Labels: oozie
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> oozie server uses a system configurable property to define the default
> dataset initial-instance, e.g., UTC
> 1970-01-01T00:00Z.
> oozie will issue a warning for any initial instance earlier than the system
> default (e.g. 1970-01-01T00:00Z).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
