> On 2012-01-12 20:51:12, Mohammad Islam wrote: > > /trunk/core/src/main/resources/oozie-default.xml, line 92 > > <https://reviews.apache.org/r/3471/diff/1/?file=68207#file68207line92> > > > > Why the PausedTransitionService is remove? > >
mistake, will add it back > On 2012-01-12 20:51:12, Mohammad Islam wrote: > > /trunk/core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java, > > line 545 > > <https://reviews.apache.org/r/3471/diff/1/?file=68206#file68206line545> > > > > The similar setParameter(..) might be needed for 'normal' user. > > That is add an 'else' block call it there (Deleted line 281) mistake, will fix. > On 2012-01-12 20:51:12, Mohammad Islam wrote: > > /trunk/core/src/main/java/org/apache/oozie/servlet/HostnameFilter.java, > > line 34 > > <https://reviews.apache.org/r/3471/diff/1/?file=68205#file68205line34> > > > > Why ThreadLocal data structure is required at this point? > > > > Is it for "static " get method. yes, to get the host of the request deeper in the request thread > On 2012-01-12 20:51:12, Mohammad Islam wrote: > > /trunk/core/src/main/java/org/apache/oozie/service/ProxyUserService.java, > > line 1 > > <https://reviews.apache.org/r/3471/diff/1/?file=68204#file68204line1> > > > > Please add the license header. k > On 2012-01-12 20:51:12, Mohammad Islam wrote: > > /trunk/core/src/main/java/org/apache/oozie/service/GroupsService.java, line > > 26 > > <https://reviews.apache.org/r/3471/diff/1/?file=68203#file68203line26> > > > > I know these classes are based on Hadoop implementations. > > Adding a short comment about the high level functionality of this class > > will make it better readable. k - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3471/#review4330 ----------------------------------------------------------- On 2012-01-12 17:31:21, Alejandro Abdelnur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3471/ > ----------------------------------------------------------- > > (Updated 2012-01-12 17:31:21) > > > Review request for oozie. > > > Summary > ------- > > Adds doAs capability to oozie HTTP API, oozie Java API and oozie CLI. > > The GroupsService and ProxyUserService are a copycat from the code > implemented for Hadoop httpfs > > > This addresses bug OOZIE-652. > https://issues.apache.org/jira/browse/OOZIE-652 > > > Diffs > ----- > > /trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1229764 > /trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java > 1229764 > /trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 1229764 > /trunk/core/pom.xml 1229764 > /trunk/core/src/main/conf/oozie-site.xml 1229764 > /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1229764 > /trunk/core/src/main/java/org/apache/oozie/service/GroupsService.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/service/ProxyUserService.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/servlet/HostnameFilter.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java > 1229764 > /trunk/core/src/main/resources/oozie-default.xml 1229764 > /trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1229764 > /trunk/core/src/test/java/org/apache/oozie/service/TestGroupsService.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/service/TestProxyUserService.java > PRE-CREATION > /trunk/core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java > 1229764 > > /trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java > 1229764 > > /trunk/core/src/test/java/org/apache/oozie/servlet/TestAuthFilterAuthOozieClient.java > 1229764 > /trunk/core/src/test/java/org/apache/oozie/servlet/TestHostnameFilter.java > PRE-CREATION > /trunk/docs/src/site/twiki/AG_Install.twiki 1229764 > /trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1229764 > /trunk/pom.xml 1229764 > /trunk/webapp/src/main/webapp/WEB-INF/web.xml 1229764 > > Diff: https://reviews.apache.org/r/3471/diff > > > Testing > ------- > > augmented testcases to test doAs. > > built, install and run examples as doas user > > > Thanks, > > Alejandro > >
