[ 
https://issues.apache.org/jira/browse/OOZIE-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185239#comment-13185239
 ] 

[email protected] commented on OOZIE-652:
-----------------------------------------------------



bq.  On 2012-01-12 20:51:12, Mohammad Islam wrote:
bq.  > /trunk/core/src/main/resources/oozie-default.xml, line 92
bq.  > <https://reviews.apache.org/r/3471/diff/1/?file=68207#file68207line92>
bq.  >
bq.  >     Why the PausedTransitionService is remove?
bq.  >

mistake, will add it back


bq.  On 2012-01-12 20:51:12, Mohammad Islam wrote:
bq.  > /trunk/core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java, 
line 545
bq.  > <https://reviews.apache.org/r/3471/diff/1/?file=68206#file68206line545>
bq.  >
bq.  >     The similar setParameter(..) might be needed for 'normal' user.
bq.  >     That is add an 'else' block call it there (Deleted line 281)

mistake, will fix.


bq.  On 2012-01-12 20:51:12, Mohammad Islam wrote:
bq.  > /trunk/core/src/main/java/org/apache/oozie/servlet/HostnameFilter.java, 
line 34
bq.  > <https://reviews.apache.org/r/3471/diff/1/?file=68205#file68205line34>
bq.  >
bq.  >     Why ThreadLocal data structure is required at this point?
bq.  >     
bq.  >     Is it for "static " get method.

yes, to get the host of the request deeper in the request thread


bq.  On 2012-01-12 20:51:12, Mohammad Islam wrote:
bq.  > 
/trunk/core/src/main/java/org/apache/oozie/service/ProxyUserService.java, line 1
bq.  > <https://reviews.apache.org/r/3471/diff/1/?file=68204#file68204line1>
bq.  >
bq.  >     Please add the license header.

k


bq.  On 2012-01-12 20:51:12, Mohammad Islam wrote:
bq.  > /trunk/core/src/main/java/org/apache/oozie/service/GroupsService.java, 
line 26
bq.  > <https://reviews.apache.org/r/3471/diff/1/?file=68203#file68203line26>
bq.  >
bq.  >     I know these classes are based on Hadoop implementations. 
bq.  >     Adding a short comment about the high level functionality of this 
class will make it better readable.

k


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3471/#review4330
-----------------------------------------------------------


On 2012-01-12 17:31:21, Alejandro Abdelnur wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3471/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-12 17:31:21)
bq.  
bq.  
bq.  Review request for oozie.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Adds doAs capability to oozie HTTP API, oozie Java API and oozie CLI.
bq.  
bq.  The GroupsService and ProxyUserService are a copycat from the code 
implemented for Hadoop httpfs
bq.  
bq.  
bq.  This addresses bug OOZIE-652.
bq.      https://issues.apache.org/jira/browse/OOZIE-652
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1229764 
bq.    /trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 
1229764 
bq.    
/trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 
1229764 
bq.    /trunk/core/pom.xml 1229764 
bq.    /trunk/core/src/main/conf/oozie-site.xml 1229764 
bq.    /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1229764 
bq.    /trunk/core/src/main/java/org/apache/oozie/service/GroupsService.java 
PRE-CREATION 
bq.    /trunk/core/src/main/java/org/apache/oozie/service/ProxyUserService.java 
PRE-CREATION 
bq.    /trunk/core/src/main/java/org/apache/oozie/servlet/HostnameFilter.java 
PRE-CREATION 
bq.    /trunk/core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 
1229764 
bq.    /trunk/core/src/main/resources/oozie-default.xml 1229764 
bq.    /trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 
1229764 
bq.    
/trunk/core/src/test/java/org/apache/oozie/service/TestGroupsService.java 
PRE-CREATION 
bq.    
/trunk/core/src/test/java/org/apache/oozie/service/TestProxyUserService.java 
PRE-CREATION 
bq.    
/trunk/core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 
1229764 
bq.    
/trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 
1229764 
bq.    
/trunk/core/src/test/java/org/apache/oozie/servlet/TestAuthFilterAuthOozieClient.java
 1229764 
bq.    
/trunk/core/src/test/java/org/apache/oozie/servlet/TestHostnameFilter.java 
PRE-CREATION 
bq.    /trunk/docs/src/site/twiki/AG_Install.twiki 1229764 
bq.    /trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1229764 
bq.    /trunk/pom.xml 1229764 
bq.    /trunk/webapp/src/main/webapp/WEB-INF/web.xml 1229764 
bq.  
bq.  Diff: https://reviews.apache.org/r/3471/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  augmented testcases to test doAs.
bq.  
bq.  built, install and run examples as doas user
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Alejandro
bq.  
bq.


                
> Add proxyuser capabilities to Oozie HTTP API
> --------------------------------------------
>
>                 Key: OOZIE-652
>                 URL: https://issues.apache.org/jira/browse/OOZIE-652
>             Project: Oozie
>          Issue Type: New Feature
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>
> Enable users to submit jobs to oozie on behalf of another users providing 
> similar functionality to hadoop proxy user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to