----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3606/#review4587 -----------------------------------------------------------
overall very good work. Adding some test cases might complete the patch. branches/3.1/core/src/main/java/org/apache/oozie/util/DateUtils.java <https://reviews.apache.org/r/3606/#comment10220> why 24 is valid hour? it 00 on the next day? branches/3.1/core/src/main/java/org/apache/oozie/util/DateUtils.java <https://reviews.apache.org/r/3606/#comment10221> same. why 60> why not 59? - Mohammad On 2012-01-25 04:55:10, Jeremy Hanna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3606/ > ----------------------------------------------------------- > > (Updated 2012-01-25 04:55:10) > > > Review request for oozie and Harsh J. > > > Summary > ------- > > Per the ticket, added some simple validation to the date logic. It may need > some extra attention as I'm new to contributing to the source. Also not sure > if using Joda time is on the table. > > > This addresses bug https://issues.apache.org/jira/browse/OOZIE-649. > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/OOZIE-649 > > > Diffs > ----- > > branches/3.1/core/src/main/java/org/apache/oozie/util/DateUtils.java > 1231531 > > Diff: https://reviews.apache.org/r/3606/diff > > > Testing > ------- > > > Thanks, > > Jeremy > >
