[
https://issues.apache.org/jira/browse/OOZIE-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197541#comment-13197541
]
[email protected] commented on OOZIE-665:
-----------------------------------------------------
bq. On 2012-01-31 22:08:10, Alejandro Abdelnur wrote:
bq. >
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java,
line 201
bq. > <https://reviews.apache.org/r/3708/diff/2/?file=71463#file71463line201>
bq. >
bq. > Why not using os.writeln(line) instead of adding '\n'?
bq.
bq. Mohammad Islam wrote:
bq. that was the original code. The bug was : oozie wrote all key=value in
the same line. Although the application is writing into different lines.
bq.
bq. 'line' doesn't contain "\n". that's why it is writing into the same
line. The property loader reads each line as one key=value. In this case,
multiple key=value should in different line.
bq. Therefore, we need to write as the user application is writing.
bq.
bq.
bq.
bq. Alejandro Abdelnur wrote:
bq. My bad, but instead adding '\n' the BufferedWriter.newLine() method
could be used and that will use the line separator of the platform.
yes. I got the same feedback(use newLine) from Virag. that is better choice.
I will do that.
- Mohammad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3708/#review4713
-----------------------------------------------------------
On 2012-01-31 20:47:57, Mohammad Islam wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3708/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-31 20:47:57)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Shell action doesn't capture multiple key-value pairs
bq.
bq.
bq. This addresses bug OOZIE-665.
bq. https://issues.apache.org/jira/browse/OOZIE-665
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java
1238106
bq.
bq. Diff: https://reviews.apache.org/r/3708/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mohammad
bq.
bq.
> Shell action doesn't capture multiple key-value pairs
> -----------------------------------------------------
>
> Key: OOZIE-665
> URL: https://issues.apache.org/jira/browse/OOZIE-665
> Project: Oozie
> Issue Type: Bug
> Reporter: Mohammad Kamrul Islam
> Assignee: Mohammad Kamrul Islam
>
> It works for one pair of key value. For multiple pairs, it makes then into
> one key value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
