----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3752/#review4936 -----------------------------------------------------------
there is no patch attached - Alejandro On 2012-02-03 09:33:10, shwethags wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3752/ > ----------------------------------------------------------- > > (Updated 2012-02-03 09:33:10) > > > Review request for oozie. > > > Summary > ------- > > I have an EL extension today(0,0) which maps to start day of nominal time. > This is used to specify startInstance, endInstance and instance in dataIn and > dataOut of coordinator. > > In CoordCommandUtils.resolveInstanceRange(), getInstanceNumber has to return > the instance number with respect to current. So, for coord-action-create-inst > context, I have mapped today to current and hence getInstanceNumber returns > the correct number. But later in resolveInstanceRange(), getFuncType is > called with startInstance value which is today in this case and it maps to > UNEXPECTED and throws up. getFuncType should be passed the evaluation of > coord-action-create-inst context > > > This addresses bug OOZIE-674. > https://issues.apache.org/jira/browse/OOZIE-674 > > > Diffs > ----- > > > Diff: https://reviews.apache.org/r/3752/diff > > > Testing > ------- > > UT - TestCoordActionMaterializeCommand > Tested with coord:current instance range and EL extension > > > Thanks, > > shwethags > >
