-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3759/#review4940
-----------------------------------------------------------



http://svn.apache.org/repos/asf/incubator/oozie/trunk/bin/mkdistro.sh
<https://reviews.apache.org/r/3759/#comment10858>

    shouldn't we have different CI scripts instead adding things here?



http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/pom.xml
<https://reviews.apache.org/r/3759/#comment10856>

    This goes for all POMs: we should not remove the version of the module, 
even it it gets the one from the parent. Maven has same well known issues with 
this.  So it is better to keep it. Plus the versions plugin handles this 
properlty


- Alejandro


On 2012-02-04 01:08:26, Prakhar Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3759/
> -----------------------------------------------------------
> 
> (Updated 2012-02-04 01:08:26)
> 
> 
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
> 
> 
> Summary
> -------
> 
> Right now automation of Oozie build is difficult as there is no (easy) way to 
> programmitcally change version# in pom.xml files. This jira is to address 
> this issue. Mainly to make changes in pom.xml and build files 
> (bin/mkdistro.sh) so that version# can be controlled through the use of maven 
> versions plugin.
> 
> Changes are mainly to pom.xml files, bin/mkdistro.sh (to change version# 
> before building) and a new file (build_version) which can be used by 
> automated tasks to communicate the version# being built to other tasks.
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/OOZIE-679.
>     
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/OOZIE-679
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/bin/mkdistro.sh 
> 1240415 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/build_version 
> PRE-CREATION 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/pom.xml 
> 1240415 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/pom.xml 1240415 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/distro/pom.xml 
> 1240415 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/docs/pom.xml 1240415 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/examples/pom.xml 
> 1240415 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/minitest/pom.xml 
> 1240415 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/pom.xml 1240415 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/sharelib/hive/pom.xml 
> 1240415 
>   
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/sharelib/oozie/pom.xml 
> 1240415 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/sharelib/pig/pom.xml 
> 1240415 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/sharelib/pom.xml 
> 1240415 
>   
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/sharelib/sqoop/pom.xml 
> 1240415 
>   
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/sharelib/streaming/pom.xml
>  1240415 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/webapp/pom.xml 
> 1240415 
> 
> Diff: https://reviews.apache.org/r/3759/diff
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Prakhar
> 
>

Reply via email to