----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3756/#review4982 -----------------------------------------------------------
Some more comments. trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java <https://reviews.apache.org/r/3756/#comment10957> This needs to be updated since the arguments have changed. trunk/core/src/main/java/org/apache/oozie/ErrorCode.java <https://reviews.apache.org/r/3756/#comment10958> How did the fork/join error messages creep into this patch? trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/3756/#comment10945> Can you change this to status=<S1>[;status=<S2>]* ? trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java <https://reviews.apache.org/r/3756/#comment10950> Move the catch to the previous line to conform to Java coding standards. trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java <https://reviews.apache.org/r/3756/#comment10948> Can this be rephrased as "The only valid filter is 'status'" ? trunk/core/src/main/java/org/apache/oozie/ErrorCode.java <https://reviews.apache.org/r/3756/#comment10952> How is this error different from E0420 ? trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java <https://reviews.apache.org/r/3756/#comment10953> Can this be changed to filterList ? trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java <https://reviews.apache.org/r/3756/#comment10954> Can you change filter to filterList or filters ? trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java <https://reviews.apache.org/r/3756/#comment10956> Minor comment - I am assuming that this method will not be used by another method since the assertions are very specific. In particular, as the comment on line #114 states, its assumed that only RUNNING jobs are returned - Santhosh On 2012-02-09 01:38:25, Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3756/ > ----------------------------------------------------------- > > (Updated 2012-02-09 01:38:25) > > > Review request for oozie. > > > Summary > ------- > > https://issues.apache.org/jira/browse/OOZIE-677 > > > This addresses bug oozie-677. > https://issues.apache.org/jira/browse/oozie-677 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1242197 > trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1242197 > trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 1242197 > trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1242197 > trunk/core/src/main/java/org/apache/oozie/BundleEngine.java 1242197 > trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1242197 > trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1242197 > trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1242197 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java > 1242197 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java > 1242197 > trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1242197 > trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java > 1242197 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java > 1242197 > > trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java > 1242197 > trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1242197 > > Diff: https://reviews.apache.org/r/3756/diff > > > Testing > ------- > > Test cases added > Checked filter option thru. command line after running cron example > > > Thanks, > > Virag > >
