----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3883/#review5064 -----------------------------------------------------------
A few comments. trunk/core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java <https://reviews.apache.org/r/3883/#comment11110> Extra line trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java <https://reviews.apache.org/r/3883/#comment11111> Extra line trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java <https://reviews.apache.org/r/3883/#comment11103> Change the method to testTransitionFailure1() trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java <https://reviews.apache.org/r/3883/#comment11104> Change the method to testTransitionFailure2() trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java <https://reviews.apache.org/r/3883/#comment11105> Include a message for the failure. trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java <https://reviews.apache.org/r/3883/#comment11106> Change the method to testTransitionFailure3() trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java <https://reviews.apache.org/r/3883/#comment11107> Include a message for the failure. trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java <https://reviews.apache.org/r/3883/#comment11109> Can a fork have multiple incoming edges? trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java <https://reviews.apache.org/r/3883/#comment11108> Include a message for the failure. - Santhosh On 2012-02-13 19:10:15, Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3883/ > ----------------------------------------------------------- > > (Updated 2012-02-13 19:10:15) > > > Review request for oozie and Santhosh Srinivasan. > > > Summary > ------- > > https://issues.apache.org/jira/browse/OOZIE-693 > > > This addresses bug OOZIE-693. > https://issues.apache.org/jira/browse/OOZIE-693 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1243647 > > trunk/core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java > 1243647 > > trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > 1243647 > > Diff: https://reviews.apache.org/r/3883/diff > > > Testing > ------- > > Few tests added > > > Thanks, > > Virag > >
