> On 2012-02-22 03:11:41, Mohammad Islam wrote: > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java, > > line 43 > > <https://reviews.apache.org/r/3991/diff/3/?file=78564#file78564line43> > > > > Good work. > > For further improvements, we can make it "hadoopJobs" a public final > > variable in this class. Andd all others can use that variable instead of > > the string constant.
will do - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3991/#review5261 ----------------------------------------------------------- On 2012-02-21 23:16:56, Alejandro Abdelnur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3991/ > ----------------------------------------------------------- > > (Updated 2012-02-21 23:16:56) > > > Review request for oozie. > > > Summary > ------- > > OOZIE-700,OOZIE-702,OOZIE-703,OOZIE-704 combo review. > > These patches build on top of each other, the first patch is the first > revision, the second patch is second revision, etc, etc. Review them one by > one by selecting a diff between the current and previous revision of the patch > > > This addresses bugs OOZIE-700, OOZIE-702, OOZIE-703, and OOZIE-704. > https://issues.apache.org/jira/browse/OOZIE-700 > https://issues.apache.org/jira/browse/OOZIE-702 > https://issues.apache.org/jira/browse/OOZIE-703 > https://issues.apache.org/jira/browse/OOZIE-704 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java > 1292066 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java > 1292066 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java > 1292066 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java > 1292066 > trunk/core/src/test/java/org/apache/oozie/action/hadoop/SharelibUtils.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java > 1292066 > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java > 1292066 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java > 1292066 > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java > 1292066 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java > 1292066 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java > 1292066 > trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1292066 > trunk/hadooplibs/hadoop-0_23_1/pom.xml 1292066 > trunk/hadooplibs/hadoop-0_23_2/pom.xml PRE-CREATION > trunk/hadooplibs/hadoop-1_0_1/pom.xml PRE-CREATION > trunk/hadooplibs/hadoop-test-0_23_1/pom.xml 1292066 > trunk/hadooplibs/hadoop-test-0_23_2/pom.xml PRE-CREATION > trunk/hadooplibs/hadoop-test-1_0_1/pom.xml PRE-CREATION > trunk/hadooplibs/pom.xml 1292066 > trunk/pom.xml 1292066 > trunk/sharelib/hive/pom.xml 1292066 > trunk/sharelib/oozie/pom.xml 1292066 > trunk/sharelib/pig/pom.xml 1292066 > trunk/sharelib/sqoop/pom.xml 1292066 > trunk/sharelib/streaming/pom.xml 1292066 > > Diff: https://reviews.apache.org/r/3991/diff > > > Testing > ------- > > tested with hadoop-1 and hadoop-0.23. > > There are still some failures but getting closer. > > One big issue is Pig JAR which does not run with Hadoop 0.23 (PIG-2546). I've > tested by installing in my local m2 cache a Pig JAR compiled with 0.23 > > Note, for hive action to work, Hadoop 0.23 must be patched with MAPREDUCE-3884 > > > Thanks, > > Alejandro > >
