I build at my MAC and do patch test before submitting patch. After committing automatic build picks it up and do all the test.
Thanks, Mayank On Wed, Feb 22, 2012 at 4:11 PM, Mohammad Islam <[email protected]> wrote: > Hi Alejandro, > Is there any such requirement for committing to hadoop? > > > Regards, > Mohammad > > > ________________________________ > From: Mayank Bansal <[email protected]> > To: [email protected] > Cc: Mohammad Islam <[email protected]> > Sent: Wednesday, February 22, 2012 1:45 PM > Subject: Re: Feedback requested: Building in Linux/Mac/Doesn't matter > > I think just the build on MAC or Linux with all the test cases run is > suffice for committing. If there is any machine specific issue which we are > missing we should be catching that anyways in the next day build but in > Oozie case it is very less. > > As mentioned most of us have been doing it in MAC anyways so adding one > more machine to run test and then commit is a extra overhead. > > Thanks, > Mayank > > On Wed, Feb 22, 2012 at 1:32 PM, Roman Shaposhnik <[email protected]> wrote: > > > On Wed, Feb 22, 2012 at 1:26 PM, Mohammad Islam <[email protected]> > > wrote: > > > Hi, > > > Do we need to mandate that all committers should execute the full-build > > (including test cases) in Linux box? > > > > I'd be +1 on such a a requirement. > > > > > Currently most committers use the mac for this purpose. > > > > > > Pros for Linux: > > > As our product is ultimately supported/verified in Linux, our test > cases > > should be tested on the same. This will catch any machine dependent issue > > early. Otherwise we have to wait for CI commit/nightly build which could > > take 1 day. > > > > > > Cons: > > > Yet another requirement for committer! > > > > Why not fix this with a testpatch-like infrastructure? > > > > Thanks, > > Roman. > > >
