> On 2012-03-02 05:24:24, Mohamed Battisha wrote: > > branches/branch-3.1/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, > > line 791 > > <https://reviews.apache.org/r/3944/diff/5/?file=87270#file87270line791> > > > > any reason for changing it from protected to public
was trying this while changing another testcase. Reverted it. Thanks for pointing out. > On 2012-03-02 05:24:24, Mohamed Battisha wrote: > > branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java, > > line 216 > > <https://reviews.apache.org/r/3944/diff/5/?file=87277#file87277line216> > > > > in some files you setting the config before injecting the Kerberos > > Info. In others you are doing it after. > > > > I believe you should be consistent and set it before will be better Okay. Taking consistency into account. > On 2012-03-02 05:24:24, Mohamed Battisha wrote: > > branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java, > > line 232 > > <https://reviews.apache.org/r/3944/diff/5/?file=87277#file87277line232> > > > > any reason for increasing the wait time. is the new changes will impact > > the wait time Was checking before if increasing wait time allows for job status change expected. Changing it back after verifying not necessary - Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3944/#review5541 ----------------------------------------------------------- On 2012-03-02 02:56:41, Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3944/ > ----------------------------------------------------------- > > (Updated 2012-03-02 02:56:41) > > > Review request for oozie. > > > Summary > ------- > > Backporting the changes to Oozie testcases (OOZIE-691) in branch 3.1 so they > can be run against Hadoop 23 > > > This addresses bugs OOZIE-714 and OOZIE-716. > https://issues.apache.org/jira/browse/OOZIE-714 > https://issues.apache.org/jira/browse/OOZIE-716 > > > Diffs > ----- > > > branches/branch-3.1/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1244331 > > branches/branch-3.1/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java > 1244331 > > branches/branch-3.1/core/src/main/java/org/apache/oozie/service/KerberosHadoopAccessorService.java > 1244331 > > branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java > 1244331 > > branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 1244331 > > branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java > 1244331 > > branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java > 1244331 > > branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java > 1244331 > > branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java > 1244331 > > branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java > 1244331 > > branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java > 1244331 > > branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java > 1244331 > > branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java > 1244331 > > branches/branch-3.1/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java > 1244331 > > branches/branch-3.1/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java > 1244331 > > branches/branch-3.1/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java > 1244331 > > branches/branch-3.1/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java > 1244331 > > branches/branch-3.1/core/src/test/java/org/apache/oozie/util/TestClassUtils.java > 1244331 > > Diff: https://reviews.apache.org/r/3944/diff > > > Testing > ------- > > yes > > > Thanks, > > Mona > >
